Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second version of enable/disable output icon #6042

Closed
vitvakatu opened this issue Mar 22, 2023 · 5 comments · Fixed by #6122
Closed

Second version of enable/disable output icon #6042

vitvakatu opened this issue Mar 22, 2023 · 5 comments · Fixed by #6122
Assignees
Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint

Comments

@vitvakatu
Copy link
Contributor

We need a second version for the already implemented (#5928) icon, see https://github.com/orgs/enso-org/discussions/5964#discussioncomment-5386969

It should look like the already existing one, but without the stroke that crosses it:

QA Acceptance Criteria

The icon above is visible on the icons demo scene.

@vitvakatu vitvakatu moved this from ❓New to 📤 Backlog in Issues Board Mar 22, 2023
@vitvakatu vitvakatu added d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint -gui labels Mar 22, 2023
@Procrat
Copy link
Contributor

Procrat commented Mar 28, 2023

@wdanilo: Is the cut-out in the bottom left intentional? Just double-checking because we weren't sure and I couldn't find it in the Figma design.

@Procrat Procrat moved this from 📤 Backlog to 👁️ Code review in Issues Board Mar 29, 2023
@wdanilo
Copy link
Member

wdanilo commented Mar 29, 2023

@wdanilo: Is the cut-out in the bottom left intentional? Just double-checking because we weren't sure and I couldn't find it in the Figma design.

good question. It is accidental, should be removed. Thanks so much for catching it!
(I mean, in Figma I have the icon with this cutout there, but you are right, from the visual standpoint, there should be no cutout).

@Procrat
Copy link
Contributor

Procrat commented Mar 29, 2023

Great, good to know. I'll get rid of it in the PR.

@wdanilo
Copy link
Member

wdanilo commented Mar 29, 2023

Thanks again for catching it!

@vitvakatu vitvakatu moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Mar 29, 2023
@mergify mergify bot closed this as completed in #6122 Mar 29, 2023
mergify bot pushed a commit that referenced this issue Mar 29, 2023
Closes #6042. This just adds the icon to the `icons` demo scene, not to the actual product itself yet.

![arrowloops](https://user-images.githubusercontent.com/607786/228487555-1de02912-a891-40d9-9873-c1978c0c8be2.png)
@github-project-automation github-project-automation bot moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Mar 29, 2023
@enso-bot
Copy link

enso-bot bot commented Mar 30, 2023

Stijn Seghers reports a new STANDUP for yesterday (2023-03-29):

Progress: Created a second version of the icon button to enable/disable re-evaluation. Got reviewed, QA'd and merged. It should be finished by 2023-03-29.

@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants