Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildStdLib*** tasks do not re-generate the corresponding stdlib index #5999

Closed
hubertp opened this issue Mar 17, 2023 · 1 comment · Fixed by #6000
Closed

buildStdLib*** tasks do not re-generate the corresponding stdlib index #5999

hubertp opened this issue Mar 17, 2023 · 1 comment · Fixed by #6000
Assignees
@hubertp
Labels
--bug Type: bug -build-script Category: build script p-high Should be completed in the next sprint

Comments

@hubertp
Copy link
Collaborator

hubertp commented Mar 17, 2023 •
edited
Loading

Motivation

#5700 and #5698 introduced additional step when building the distribution that builds indexes for individual stdlib components (caches and suggestions, respectively).
Library team makes a heavy use of buildStdLib*** tasks that only rebuild libraries without touching runtime. Those tasks, however, do not trigger index rebuild.

This is slowing down library team.

Expected result

sbt's buildStdlIb tasks should also rebuild indexes, if necessary.
@hubertp hubertp added p-high Should be completed in the next sprint -build-script Category: build script labels Mar 17, 2023
@hubertp hubertp self-assigned this Mar 17, 2023
@hubertp hubertp moved this from ❓New to 📤 Backlog in Issues Board Mar 17, 2023
@hubertp hubertp added the --bug Type: bug label Mar 17, 2023
hubertp added a commit that referenced this issue Mar 19, 2023
@hubertp
Generate index when invoking buildStdLib tasks
9c33cdd 
The change adds support for generating suggestions and bindings when
using the convenient task for building individual stdlib components.

Closes #5999.
hubertp added a commit that referenced this issue Mar 19, 2023
@hubertp
Generate index when invoking buildStdLib tasks
3173ebb 
The change adds support for generating suggestions and bindings when
using the convenient task for building individual stdlib components.

Closes #5999.
@hubertp hubertp mentioned this issue Mar 19, 2023
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Mar 20, 2023

Hubert Plociniczak reports a new STANDUP for yesterday (2023-03-19):

Progress: Added indexing to sbt's tasks. Continued looking at the implementation of IO contexts. It should be finished by 2023-03-19.

Next Day: Next day I will be working on the #5999 task. Address PR review, continue the work into execution contexts.

hubertp added a commit that referenced this issue Mar 27, 2023
@hubertp
Generate index when invoking buildStdLib tasks
f17214f 
The change adds support for generating suggestions and bindings when
using the convenient task for building individual stdlib components.

Closes #5999.
hubertp added a commit that referenced this issue Mar 28, 2023
@hubertp
Generate index when invoking buildStdLib tasks
7740029 
The change adds support for generating suggestions and bindings when
using the convenient task for building individual stdlib components.

Closes #5999.
@mergify mergify bot closed this as completed in #6000 Mar 28, 2023
mergify bot pushed a commit that referenced this issue Mar 28, 2023
@hubertp
Generate index when invoking buildStdLib tasks (#6000)
49e2c5a 
The change adds support for generating suggestions and bindings when using the convenient task for building individual stdlib components. By default commands do not generate index since it adds build time. But `buildStdLibAllWithIndex` will.

Closes #5999.
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hubertp hubertp

Labels
--bug Type: bug -build-script Category: build script p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate index when invoking buildStdLib tasks enso-org/enso
1 participant
@hubertp