Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A help tooltip when hovering the icons near the node. #5933

Closed
Tracked by #5899
vitvakatu opened this issue Mar 14, 2023 · 2 comments · Fixed by #6035
Closed
Tracked by #5899

A help tooltip when hovering the icons near the node. #5933

vitvakatu opened this issue Mar 14, 2023 · 2 comments · Fixed by #6035
Assignees
@Procrat
Labels
d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Milestone
Design Partners

Comments

@vitvakatu
Copy link
Contributor

vitvakatu commented Mar 14, 2023 •
edited
Loading

A tooltip with brief information about the icon should be displayed for:

  1. Output context switch icon
  2. Visualization switch icon

QA Acceptance Criteria

GIVEN an open project or demo scene
WHEN I hover the visualization switch icon to the right of the node
THEN A tooltip with a short description of the button is displayed
THEN A tooltip disappears after a short delay

WHEN I hover the output context switch icon to the right of the node
THEN A tooltip with a short description of the button is displayed
THEN A tooltip disappears after a short delay
@vitvakatu vitvakatu mentioned this issue Mar 14, 2023
Closed
@vitvakatu vitvakatu added d-easy Difficulty: little prior knowledge required p-low Low priority g-graph-editor p-medium Should be completed in the next few sprints and removed p-low Low priority labels Mar 14, 2023
@vitvakatu vitvakatu moved this from ❓New to 📤 Backlog in Issues Board Mar 14, 2023
@vitvakatu vitvakatu added this to the Design Partners milestone Mar 14, 2023
@enso-bot enso-bot bot mentioned this issue Mar 17, 2023
Closed
@vitvakatu vitvakatu moved this from 📤 Backlog to 🔧 Implementation in Issues Board Mar 20, 2023
@enso-bot
Copy link

enso-bot bot commented Mar 21, 2023

Stijn Seghers reports a new STANDUP for today (2023-03-21):

Progress: I learned about our FRP framework for a bit and then started on adding those tooltips. I'm hoping to make this "tooltip on hover" pattern reusable since we're already doing this in a bunch of places. It should be finished by 2023-03-23.

@Procrat Procrat mentioned this issue Mar 22, 2023
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Mar 22, 2023

Stijn Seghers reports a new STANDUP for today (2023-03-22):

Progress: I've attached tooltips to all ToggleButton components. Added some tests. PR is ready for review. It should be finished by 2023-03-22.

@Procrat Procrat moved this from 🔧 Implementation to 👁️ Code review in Issues Board Mar 22, 2023
@Procrat Procrat linked a pull request Mar 22, 2023 that will close this issue
Add tooltips to the action bar #6035
Merged
5 tasks
@Procrat Procrat moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Mar 27, 2023
@MichaelMauderer MichaelMauderer moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Mar 27, 2023
@mergify mergify bot closed this as completed in #6035 Mar 27, 2023
mergify bot pushed a commit that referenced this issue Mar 27, 2023
@Procrat
Add tooltips to the action bar (#6035)
b977b5a 
Implements #5933: adding tooltips to the buttons next to nodes.

To make the UI consistent, I've added tooltips to the `ToggleButton` class directly, since whenever you have an icon button, it seems helpful to have a tooltip.

`ToggleButton` is only used for the profiling button in the top-right corner and the buttons next to nodes. The output context switch button [isn't implemented yet](#5929), but once it is, adding a tooltip should be one-liner.

![Recording 2023-03-22 at 17 21 58](https://user-images.githubusercontent.com/607786/226972920-81033b37-001f-49eb-9fc6-453120f01760.gif)
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Procrat Procrat

Labels
d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Projects
Issues Board
Archived in project
Milestone
Design Partners
Development

Successfully merging a pull request may close this issue.

Add tooltips to the action bar enso-org/enso
2 participants
@Procrat @vitvakatu