-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying code to add/remove context switch expressions. #5926
Comments
Shouldn't the |
You're right, fixed. |
Ilya Bogdanov reports a new STANDUP for the last Friday (2023-03-17): Progress: Started working on a task. Implemented a draft version of context switch expression recognition. It should be finished by 2023-03-27. Next Day: Next day I will be working on the #5356 task. fixing issues with recognition of qualified names in CB |
Ilya Bogdanov reports a new STANDUP for today (2023-03-23): Progress: Refactored expression recognition, implementing generation. It should be finished by 2023-03-27. Next Day: Next day I will be working on the same task. finish the implementation and open a PR |
Ilya Bogdanov reports a new STANDUP for yesterday (2023-03-27): Progress: This is a standup for 2023-03-24. Updated the code to the most recent version of the design, implemented cleaning of the switch expressions, improved unit tests. It should be finished by 2023-03-27. |
Ilya Bogdanov reports a new 🔴 DELAY for yesterday (2023-03-28): Summary: There is 3 days delay in implementation of the Modifying code to add/remove context switch expressions. (#5926) task. 1 day is vacation Delay Cause: spent additional day preparing a PR, and also allocating some time for slower review |
Ilya Bogdanov reports a new STANDUP for yesterday (2023-03-28): Progress: Opened a PR for context switch expressions, and fixed the issue with CB crash on certain inputs which was reported recently. It should be finished by 2023-03-30. |
Ilya Bogdanov reports a new STANDUP for yesterday (2023-03-30): Progress: Addressing review comments, QA testing of other tasks. It should be finished by 2023-03-30. |
Closes #5926 Implements controllers side of adding and removing context switch expressions for the nodes. Example using the `skip` button (while the actual context switch button is not ready). https://user-images.githubusercontent.com/6566674/228373412-7da83b0c-6cdf-495d-b1ec-30c438c0f411.mp4 https://user-images.githubusercontent.com/6566674/228373426-7aa5699b-2aa1-4299-9d85-b22371c4a063.mp4 # Important Notes No visual changes to the IDE were made.
Ilya Bogdanov reports a new 🔴 DELAY for the last Friday (2023-03-31): Summary: There is 4 days delay in implementation of the Modifying code to add/remove context switch expressions. (#5926) task. 2 days are weekends Delay Cause: Addressing review comments and QA review |
Ilya Bogdanov reports a new STANDUP for the last Friday (2023-03-31): Progress: Finished addressing review comments, and planned additional execution contexts issues with Adam. It should be finished by 2023-04-03. |
We need an API on the controller side to recognize, add, remove, and modify context switch expressions inside a single node.
Context switch expression looks like the following:
We support two execution modes (
in
argument):development
andproduction
.Two switch expressions can be nested one into the other:
We do not support more than two chained expressions, nor do we support these patterns inside subexpressions.
The modification includes switching from
enable_context
todisable_context
, and also changing themode
in thein
argument.We only recognize fully qualified names
Standard.Base.Runtime.enable_context
andStandard.Base.Runtime.enable_context
.QA Acceptance Criteria
See test cases in the table – everything should be supported.
The text was updated successfully, but these errors were encountered: