Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying code to add/remove context switch expressions. #5926

Closed
Tracked by #5899
vitvakatu opened this issue Mar 14, 2023 · 10 comments · Fixed by #6121
Closed
Tracked by #5899

Modifying code to add/remove context switch expressions. #5926

vitvakatu opened this issue Mar 14, 2023 · 10 comments · Fixed by #6121
Assignees
Labels
d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint

Comments

@vitvakatu
Copy link
Contributor

vitvakatu commented Mar 14, 2023

We need an API on the controller side to recognize, add, remove, and modify context switch expressions inside a single node.

Context switch expression looks like the following:

Standard.Base.Runtime.enable_context "Output" in="mode" <| rest_of_the_expression
Standard.Base.Runtime.disable_context "Output" in="mode" <| rest_of_the_expression

We support two execution modes (in argument): development and production.

Two switch expressions can be nested one into the other:

Standard.Base.Runtime.enable_context "Output" in="mode" <| Standard.Base.Runtime.enable_context "Output" in="mode2" <| rest_of_the_expression

We do not support more than two chained expressions, nor do we support these patterns inside subexpressions.

The modification includes switching from enable_context to disable_context, and also changing the mode in the in argument.

We only recognize fully qualified names Standard.Base.Runtime.enable_context and Standard.Base.Runtime.enable_context.

QA Acceptance Criteria

See test cases in the table – everything should be supported.

@vitvakatu vitvakatu self-assigned this Mar 14, 2023
@vitvakatu vitvakatu added d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint -gui labels Mar 14, 2023
@vitvakatu vitvakatu moved this from ❓New to 📤 Backlog in Issues Board Mar 14, 2023
@farmaazon
Copy link
Contributor

Shouldn't the enable_context take also a context name as argument (always "output")? Or is "output" the default one?

@vitvakatu
Copy link
Contributor Author

Shouldn't the enable_context take also a context name as argument (always "output")? Or is "output" the default one?

You're right, fixed.

@vitvakatu vitvakatu added this to the Design Partners milestone Mar 14, 2023
@vitvakatu vitvakatu moved this from 📤 Backlog to 🔧 Implementation in Issues Board Mar 17, 2023
@enso-bot
Copy link

enso-bot bot commented Mar 20, 2023

Ilya Bogdanov reports a new STANDUP for the last Friday (2023-03-17):

Progress: Started working on a task. Implemented a draft version of context switch expression recognition. It should be finished by 2023-03-27.

Next Day: Next day I will be working on the #5356 task. fixing issues with recognition of qualified names in CB

@enso-bot
Copy link

enso-bot bot commented Mar 23, 2023

Ilya Bogdanov reports a new STANDUP for today (2023-03-23):

Progress: Refactored expression recognition, implementing generation. It should be finished by 2023-03-27.

Next Day: Next day I will be working on the same task. finish the implementation and open a PR

@enso-bot
Copy link

enso-bot bot commented Mar 28, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-03-27):

Progress: This is a standup for 2023-03-24. Updated the code to the most recent version of the design, implemented cleaning of the switch expressions, improved unit tests. It should be finished by 2023-03-27.

@vitvakatu vitvakatu moved this from 🔧 Implementation to 👁️ Code review in Issues Board Mar 29, 2023
@enso-bot
Copy link

enso-bot bot commented Mar 29, 2023

Ilya Bogdanov reports a new 🔴 DELAY for yesterday (2023-03-28):

Summary: There is 3 days delay in implementation of the Modifying code to add/remove context switch expressions. (#5926) task.
It will cause 0 days delay for the delivery of this weekly plan.

1 day is vacation

Delay Cause: spent additional day preparing a PR, and also allocating some time for slower review

@enso-bot
Copy link

enso-bot bot commented Mar 29, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-03-28):

Progress: Opened a PR for context switch expressions, and fixed the issue with CB crash on certain inputs which was reported recently. It should be finished by 2023-03-30.

@vitvakatu vitvakatu moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Mar 31, 2023
@enso-bot
Copy link

enso-bot bot commented Mar 31, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-03-30):

Progress: Addressing review comments, QA testing of other tasks. It should be finished by 2023-03-30.

@vitvakatu vitvakatu moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Apr 3, 2023
@mergify mergify bot closed this as completed in #6121 Apr 3, 2023
mergify bot pushed a commit that referenced this issue Apr 3, 2023
Closes #5926

Implements controllers side of adding and removing context switch expressions for the nodes.

Example using the `skip` button (while the actual context switch button is not ready).

https://user-images.githubusercontent.com/6566674/228373412-7da83b0c-6cdf-495d-b1ec-30c438c0f411.mp4


https://user-images.githubusercontent.com/6566674/228373426-7aa5699b-2aa1-4299-9d85-b22371c4a063.mp4

# Important Notes
No visual changes to the IDE were made.
@enso-bot
Copy link

enso-bot bot commented Apr 3, 2023

Ilya Bogdanov reports a new 🔴 DELAY for the last Friday (2023-03-31):

Summary: There is 4 days delay in implementation of the Modifying code to add/remove context switch expressions. (#5926) task.
It will cause 0 days delay for the delivery of this weekly plan.

2 days are weekends

Delay Cause: Addressing review comments and QA review

@enso-bot
Copy link

enso-bot bot commented Apr 3, 2023

Ilya Bogdanov reports a new STANDUP for the last Friday (2023-03-31):

Progress: Finished addressing review comments, and planned additional execution contexts issues with Adam. It should be finished by 2023-04-03.

@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants