-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ordered and unordered comparators #5818
Comments
Pavel Marek reports a new STANDUP for today (2023-03-07): Progress: Merging ordered and unordered comparators into one. This simplifies the API a lot. Seems like a straightforward change. Locally got tests working. Seems that I have a performance regression, investigating it.. It should be finished by 2023-03-09. |
Pavel Marek reports a new STANDUP for yesterday (2023-03-09): Progress: Discovered that Meta.is_same_object is very slow and analyzing it. It should be finished by 2023-03-09. |
Pavel Marek reports a new 🔴 DELAY for today (2023-03-10): Summary: There is 4 days delay in implementation of the Merge ordered and unordered comparators (#5818) task. Delay Cause: Waiting for the last review. Also, CI is overloaded. |
Pavel Marek reports a new STANDUP for today (2023-03-10): Progress: Fixed remaining tests. PR is ready to be merged. Benchmarks are still better than before. Written some analysis to #5709 (comment). Integrating review comments. It should be finished by 2023-03-13. |
Pavel Marek reports a new STANDUP for the provided date (2023-03-08): Progress: Benchmarks on sieve.enso 3x faster, on EqualsBenchmarks 2x faster. Ready to merge, waiting for some reviews. It should be finished by 2023-03-13. |
Merge ordered and unordered comparators into a single comparator with signature:
Since #5778, it is no longer necessary to differentiate between ordered and unordered comparators.
Related discussion:
This change should also improve the performance.
Follow-up of #5771.
The text was updated successfully, but these errors were encountered: