Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in component browser when screen scaling is not an integer. #5807

Closed
2 tasks done
sylwiabr opened this issue Mar 3, 2023 · 4 comments · Fixed by #5820
Closed
2 tasks done

Icons in component browser when screen scaling is not an integer. #5807

sylwiabr opened this issue Mar 3, 2023 · 4 comments · Fixed by #5820
Assignees
Labels
--bug Type: bug --regression Important: regression p-highest Should be completed ASAP

Comments

@sylwiabr
Copy link
Member

sylwiabr commented Mar 3, 2023

Discord username

No response

What type of issue is this?

Permanent – Ocurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

image

Expected behaviour

Zrzut ekranu 2023-03-3 o 16 12 37

How we can reproduce it?

No response

Screenshots or screencasts

No response

Enso Version

Nightly 3.03.2023

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

Windows

Operating System Version

No response

Hardware you are using

No response

@sylwiabr sylwiabr added p-highest Should be completed ASAP --bug Type: bug g-component-browser --regression Important: regression triage labels Mar 3, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Mar 3, 2023
@sylwiabr sylwiabr changed the title Icons in left panel of component browser are broken on Windows Icons in component browser are broken on Windows Mar 3, 2023
@farmaazon farmaazon self-assigned this Mar 3, 2023
@farmaazon farmaazon removed the triage label Mar 3, 2023
@farmaazon farmaazon moved this from ❓New to 🔧 Implementation in Issues Board Mar 3, 2023
@farmaazon
Copy link
Contributor

I didn't reproduce it on Windows. Perhaps some hardware also plays a role in this issue.

@farmaazon
Copy link
Contributor

The cached_shape debug scene shows, that the texture is rendered more-or-less correctly. It's reading from it what is broken.

image

image

@farmaazon
Copy link
Contributor

Reproduced and found the cause: the cache rendering behave wrong if pixel ratio is not an integer.

Workaround: change the screen scaling on your system to 1 or 2.

@farmaazon farmaazon changed the title Icons in component browser are broken on Windows Icons in component browser when screen scaling is not an integer. Mar 3, 2023
@farmaazon farmaazon added this to the Design Partners milestone Mar 6, 2023
@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Mar 7, 2023
@enso-bot
Copy link

enso-bot bot commented Mar 7, 2023

Adam Obuchowicz reports a new STANDUP for yesterday (2023-03-06):

Progress: Implemented the fix and tested it on Windows It should be finished by 2023-03-07.

Next Day: Next day I will be working on the #5620 task. Finish opened PRs and investigate the blank visualization issue.

@farmaazon farmaazon moved this from 👁️ Code review to 🟢 Accepted in Issues Board Mar 8, 2023
mwu-tow pushed a commit that referenced this issue Mar 10, 2023
Fixes #5807 

When implementing [cached icons in the Component Browser](#5779), I assumed pixel_ratio may be only integral (1.0 on normal machines and 2.0 on Retina), but I forgot Windows by default scales its UI by 1.25, breaking the icons entirely.
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug --regression Important: regression p-highest Should be completed ASAP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants