Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualization Preview does not work #5639

Closed
farmaazon opened this issue Feb 13, 2023 · 2 comments · Fixed by #5757
Closed

Visualization Preview does not work #5639

farmaazon opened this issue Feb 13, 2023 · 2 comments · Fixed by #5757
Assignees
@farmaazon @galin-enso
Labels
--bug Type: bug --regression Important: regression p-high Should be completed in the next sprint
Milestone
Beta Release

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Feb 13, 2023 •
edited by vitvakatu
Loading

image

The visualization preview stopped working between Thursday and Friday nightly release

QA: @vitvakatu
@farmaazon farmaazon converted this from a draft issue Feb 13, 2023
@farmaazon farmaazon added --bug Type: bug -gui --regression Important: regression p-high Should be completed in the next sprint labels Feb 13, 2023
@farmaazon farmaazon assigned farmaazon and galin-enso and unassigned farmaazon Feb 13, 2023
@sylwiabr sylwiabr added this to the Beta Release milestone Feb 13, 2023
@enso-bot enso-bot bot mentioned this issue Feb 21, 2023
Closed
@galin-enso galin-enso moved this from 📤 Backlog to 🔧 Implementation in Issues Board Feb 22, 2023
@galin-enso galin-enso mentioned this issue Feb 23, 2023
Merged
4 tasks
@enso-bot
Copy link

enso-bot bot commented Feb 23, 2023

Galin Bajlekov reports a new STANDUP for today (2023-02-23):

Progress: Tracked down and fixed a regression in which the visualization preview was empty when adding new nodes. It should be finished by 2023-02-24.

Next Day: Next day I will be working on the #5639 task. I'll test the changes extensively, clean up the PR and open it for code review.

@enso-bot
Copy link

enso-bot bot commented Feb 24, 2023

Galin Bajlekov reports a new STANDUP for today (2023-02-24):

Progress: I've tested the visualization preview fix to ensure the fix does not interfere with other behavior and no new regression is introduced. It should be finished by 2023-02-24.

Next Day: Next day I will be working on the #5639 task. Last day at Enso. Thank you and good luck!

@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Feb 27, 2023
@farmaazon farmaazon self-assigned this Feb 27, 2023
@mergify mergify bot closed this as completed in #5757 Feb 27, 2023
mergify bot pushed a commit that referenced this issue Feb 27, 2023
@galin-enso
Fix missing visualization preview in CB (#5757)
b8ceaec 
Closes #5639

This PR fixes a regression introduced in #4120, due to which new nodes that were being edited had an empty visualization preview. Now newly created visualization containers do get a default visualization set even before the visualization's input type is set.

https://user-images.githubusercontent.com/117099775/221256294-c87a50da-c8b0-4f00-bf84-f5ae551fca72.mp4
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 27, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farmaazon farmaazon

@galin-enso galin-enso

Labels
--bug Type: bug --regression Important: regression p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Fix missing visualization preview in CB enso-org/enso
3 participants
@farmaazon @sylwiabr @galin-enso