Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraalVM Bump 23.0 to resolve BigInteger issues #5300

Closed
1 task done
wdanilo opened this issue Feb 5, 2023 · 16 comments · Fixed by #7176
Closed
1 task done

GraalVM Bump 23.0 to resolve BigInteger issues #5300

wdanilo opened this issue Feb 5, 2023 · 16 comments · Fixed by #7176
Assignees
Labels
-compiler p-low Low priority x-new-feature Type: new feature request

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

Official BigInteger support has been integrated into forthcoming GraalVM 23.0: https://github.com/oracle/graal/pull/5490/files#diff-b9f3acd7cf907a1ea1fa5dd88bcb3c544622d1665cea25cdf1ffe54f4928738cR991. Use it and remove the hacks currently in place.

Discord discussion: https://discord.com/channels/401396655599124480/1045300007995179048

Related:

Tasks:

Original issue is here.

Follow-up issues

@jdunkerley
Copy link
Member

Currently not released and this isn't yet resolved in GraalVM.

@jdunkerley jdunkerley removed this from Issues Board Feb 7, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone Feb 28, 2023
@jdunkerley jdunkerley moved this from ❓New to ⚙️ Design in Issues Board Feb 28, 2023
@jdunkerley jdunkerley moved this from ⚙️ Design to 📤 Backlog in Issues Board Feb 28, 2023
@JaroslavTulach
Copy link
Member

As of yesterday:

next feature release will go live on June 13.

e.g. GraalVM 23.x will not appear sooner than on June 13.

@jdunkerley jdunkerley removed this from the Beta Release milestone May 30, 2023
@JaroslavTulach
Copy link
Member

GraalVM 23.0 is out and it comes with fitsInBigInteger support.

@jdunkerley
Copy link
Member

As is now released can we investigate the complexity involved in this ticket and then we can assess if we want to do pre the sales release.

@jdunkerley jdunkerley added the s-info-needed Status: more information needed from submitter label Jun 27, 2023
@Akirathan Akirathan linked a pull request Jun 30, 2023 that will close this issue
7 tasks
@enso-bot
Copy link

enso-bot bot commented Jun 30, 2023

Pavel Marek reports a new STANDUP for today (2023-06-30):

Progress: - Hacking around in the Rust build script, because of the Graal release rename - there is now no difference between java and Graal identifier. It should be finished by 2023-07-07.

@Akirathan Akirathan moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jul 3, 2023
@enso-bot
Copy link

enso-bot bot commented Jul 3, 2023

Pavel Marek reports a new STANDUP for today (2023-07-03):

Progress: - Still fixing the Rust build script such that it points to the new GraalVM community release. It should be finished by 2023-07-07.

@enso-bot
Copy link

enso-bot bot commented Jul 4, 2023

Pavel Marek reports a new STANDUP for today (2023-07-04):

Progress: - Build tool seem to be fixed

  • Removing some deprecations and warnings
  • Started with the bigInteger interop support
  • We have a lot of warnings from the Truffle DSL processor about node inlining possibilities (DSL operattions). I will ignore that for now and create a separate issue for that. It should be finished by 2023-07-07.

@enso-bot
Copy link

enso-bot bot commented Jul 5, 2023

Pavel Marek reports a new STANDUP for today (2023-07-05):

Progress: - Managed to get rid of all the remaining truffle DSL warnings.

  • BigInteger and Node inling is tracked in separate issues, and the associated warnings are suppressed.
  • Engine (Linux) job is already passing It should be finished by 2023-07-07.

@Akirathan Akirathan removed the s-info-needed Status: more information needed from submitter label Jul 7, 2023
@enso-bot
Copy link

enso-bot bot commented Jul 7, 2023

Pavel Marek reports a new 🔴 DELAY for today (2023-07-07):

Summary: There is 5 days delay in implementation of the GraalVM Bump 23.0 to resolve BigInteger issues (#5300) task.
It will cause 5 days delay for the delivery of this weekly plan.

The update of VS should be done over the weekend.

Delay Cause: Waiting for Michal to update the Visual Studio version on all Windows workers - native image build is failing on Windows.

@jdunkerley jdunkerley moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jul 10, 2023
@jdunkerley jdunkerley moved this from 👁️ Code review to 🔧 Implementation in Issues Board Jul 10, 2023
@jdunkerley jdunkerley moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jul 11, 2023
@enso-bot
Copy link

enso-bot bot commented Jul 11, 2023

Pavel Marek reports a new STANDUP for yesterday (2023-07-10):

Progress: - Tweaking Engine benchmarking tool such that it is able to plot multiple branches in the same charts.

@enso-bot
Copy link

enso-bot bot commented Jul 11, 2023

Pavel Marek reports a new STANDUP for today (2023-07-11):

Progress: - Finishing #7257

  • Looking into ProjectManager and how to tweak it to download GraalVM CE 17
  • VS on Windows is already updated - native image on windows should now work It should be finished by 2023-07-12.

@enso-bot
Copy link

enso-bot bot commented Jul 12, 2023

Pavel Marek reports a new STANDUP for today (2023-07-12):

Progress: - Fixing project-manager for the new GraalVM version It should be finished by 2023-07-12.

@enso-bot
Copy link

enso-bot bot commented Jul 13, 2023

Pavel Marek reports a new 🔴 DELAY for today (2023-07-13):

Summary: There is 7 days delay in implementation of the GraalVM Bump 23.0 to resolve BigInteger issues (#5300) task.
It will cause 7 days delay for the delivery of this weekly plan.

Delay Cause: Still hacking various parts of backend to handle new GraalVM versioning

@enso-bot
Copy link

enso-bot bot commented Jul 18, 2023

Pavel Marek reports a new STANDUP for yesterday (2023-07-17):

Progress: - Update discussion about private keyword implementation at #7088

  • First step is to make modules private Implement private modules #7304
  • Fixing version specification of GraalVM
  • QA of project-manager
  • I will have to, once again, deal with some build script issues in Rust - it seems that GraalVM fetching is failing again. It should be finished by 2023-07-19.

@enso-bot
Copy link

enso-bot bot commented Jul 18, 2023

Pavel Marek reports a new STANDUP for today (2023-07-18):

Progress: - Fixing remaining tests in RuntimeVersionManager and project-manager

  • Linux engine tests seems to succeed, except for some transient failures
  • Still need to benchmark and maybe do QA on Windows. It should be finished by 2023-07-19.

@enso-bot
Copy link

enso-bot bot commented Jul 19, 2023

Pavel Marek reports a new STANDUP for today (2023-07-19):

Progress: - Compared benchmarks - no noticeable regressions neither improvements

  • QA session on Windows with Radek
  • Making sure no backward incompatible changes are introduced to launcher and project-manager.
    • Bumping minimal engine version in the project manifest template
    • Adding more distribution/launcher/runtime version tests. It should be finished by 2023-07-19.

@mergify mergify bot closed this as completed in #7176 Jul 20, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler p-low Low priority x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants