-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of TruffleBoundary in Map.insert and Map.get #5233
Labels
Comments
Closed
4 tasks
JaroslavTulach
changed the title
HashMap/HashSet follow-up
Get rid of TruffleBoundary in Map.insert and Map.get
Apr 11, 2023
Brainstorming idea. The issue needs a partial evaluation friendly |
This was referenced May 4, 2023
3 tasks
github-project-automation
bot
moved this from 🔧 Implementation
to 🟢 Accepted
in Issues Board
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This task is automatically imported from the old Task Issue Board and it was originally created by Pavel Marek.
Original issue is here.
A follow-up of https://www.pivotaltracker.com/n/projects/2539304/stories/181027272 - the previous story got bigger than we expected, so we have decided to split it.
EnsoHashMapBuilder.get
is behindTruffleBoundary
, because a black listed method is reachable from it. It seems that the usage oforg.graalvm.collections.EconomicMap
was not a good idea for a hash map implementation after all. I partially increased the performance by adding@TruffleBoundary(allowInline = true)
on some places (bc953f9). Try to investigate the performance more, and ultimately, get rid ofTruffleBoundary
inMap.insert
andMap.get
altogether.Tasks:
hashCode
when computing==
onAtom
objectsdistinct
viaMap
(for objects that don't provide custom==
& co.)EnsoHashMap
(details in the description)For future
Map
WithWarnings
to use EnsoHashMap - MigrateWithWarnings
to useEnsoHashMap
to speed them up significantly #8682Blockers:
https://www.pivotaltracker.com/n/projects/2539304/stories/181027272 resolved
The text was updated successfully, but these errors were encountered: