-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-selection support to dropdown widget #5138
Comments
The one difficulty I can think of is passing configuration of picked options to vector elements (each element could have different option picked, and thus different config). However, as I remember, it is the WidgetFunction now (not WidgetSelection), which picks of which option a configuration should be applied. |
Refinement notes:
|
Add `Vector` AST type, corresponding to the `RawAst.Tree.Array` type (name `Array` not used for obvious reasons). This is the first step of #5138. ### Important Notes - Switched some string-based vector construction to `Vector.new`, improving type-safety. - The `Ast` changes are covered by the round-trip tests; the use-site changes have been tested manually.
Keziah Wesley reports a new STANDUP for today (2024-03-18): Progress: Implemented multiselect support in selection widget. It should be finished by 2024-03-22. Next Day: Next day I will be working on the #5138 task. Add multi-choice mode to vector widget; e2e testing. |
Keziah Wesley reports a new STANDUP for today (2024-03-19): Progress: Still working on testing. It should be finished by 2024-03-22. Next Day: Next day I will be working on the #5138 task. Finish e2e tests. |
Keziah Wesley reports a new STANDUP for yesterday (2024-03-19): Progress: Addressed backend/most testing issues. Working on maintaining dropdown state when a selection is made and the placeholder widget is replaced with an argument widget. It should be finished by 2024-03-22. Next Day: Next day I will be working on the #5138 task. Probably finish feature. |
Keziah Wesley reports a new STANDUP for today (2024-03-21): Progress: Working on resumable widgets, split off a PR with the main dropdown implementation. It should be finished by 2024-03-22. Next Day: Next day I will be working on the #5138 task. Finish up. |
Keziah Wesley reports a new STANDUP for the last Friday (2024-03-22): Progress: Refactoring interactions to support resumable widget edits It should be finished by 2024-03-22. Next Day: Next day I will be working on the #5138 task. Same task. |
Keziah Wesley reports a new 🔴 DELAY for yesterday (2024-03-25): Summary: There is 7 days delay in implementation of the Add multi-selection support to dropdown widget (#5138) task. Delay Cause: implementing |
Keziah Wesley reports a new STANDUP for yesterday (2024-03-25): Progress: New interaction model passing tests. Cleaning up some implementation details. It should be finished by 2024-03-29. Next Day: Next day I will be working on the #5138 task. PR. |
Keziah Wesley reports a new STANDUP for today (2024-03-26): Progress: Merge conflicts. Refactoring to introduce new implementation with less API change for now. It should be finished by 2024-03-29. Next Day: Next day I will be working on the #5138 task. PR. |
Keziah Wesley reports a new STANDUP for yesterday (2024-03-27): Progress: Debugging unit tests that used low-level API. Implemented logic for recognizing a port that is a successor of another (placeholder) port. It should be finished by 2024-03-29. Next Day: Next day I will be working on the #5138 task. PR. |
Keziah Wesley reports a new STANDUP for today (2024-03-28): Progress: Finished except for one issue in e2e testing. It should be finished by 2024-03-29. Next Day: Next day I will be working on the #5138 task. Fix time-traveling mocks and start next task. |
Keziah Wesley reports a new STANDUP for the last Friday (2024-03-29): Progress: Refactoring to support reactive activity states to prevent bugs caused by explicit tracking of start/stop state getting out of sync with actual interaction It should be finished by 2024-03-29. Next Day: Next day I will be working on the #5138 task. Fix test issues and start next task. |
Keziah Wesley reports a new 🔴 DELAY for yesterday (2024-04-01): Summary: There is 5 days delay in implementation of the Add multi-selection support to dropdown widget (#5138) task. Delay Cause: Issue involves a lot of design consideration for APIs for collaboration between widgets |
Keziah Wesley reports a new STANDUP for yesterday (2024-04-01): Progress: Debugging reactivity. It should be finished by 2024-04-03. Next Day: Next day I will be working on the #5138 task. Fix test issues and start next task. |
Keziah Wesley reports a new STANDUP for today (2024-04-02): Progress: Finished reactive refactor. Documented some new APIs. Debugging unexpected order of events in mocks. It should be finished by 2024-04-03. Next Day: Next day I will be working on the #5138 task. Fix test issues and start next task. |
The WidgetMultiSelection should work almost the same way as WidgetSelection, but (obviously) allow selecting multiple choices (it does not close after click at choice), and the picked items are put in List - and this list should be displayed with vector widget, because we want to allow reordering picked choices.
This task is automatically imported from the old Task Issue Board and it was originally created by Paweł Grabarz.
Original issue is here.
The text was updated successfully, but these errors were encountered: