Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User should see a spinner in visualization window while waiting for visualization content #5088

Closed
wdanilo opened this issue Feb 5, 2023 · 1 comment · Fixed by #6512
Closed

User should see a spinner in visualization window while waiting for visualization content #5088

wdanilo opened this issue Feb 5, 2023 · 1 comment · Fixed by #6512
Assignees
@MichaelMauderer
Labels
-viz p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone
Design Partners

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by Sylwia Brodacka.
Original issue is here.

Team

Technical Designer: ...
Implementer: ...
Acceptance/QA: ...

Why

As an end user
I want to see a spinner in visualization window
So that I know the product is not dead and engine is processing my data

Acceptance Criteria

Scenario: 
GIVEN [I want to have a preview of a large nested table]
WHEN [I open a visualization and wait for results]
THEN [I can see a spinner in visualisation window]

Notes

Resources
@wdanilo wdanilo added this to the Beta Release milestone Feb 6, 2023
@sylwiabr sylwiabr removed the p-low Low priority label Feb 6, 2023
@sylwiabr sylwiabr moved this to 📤 Backlog in Issues Board Feb 6, 2023
@farmaazon farmaazon mentioned this issue Feb 10, 2023
Closed
2 tasks
@farmaazon farmaazon added p-medium Should be completed in the next few sprints g-graph-editor labels Feb 21, 2023
@enso-bot enso-bot bot mentioned this issue May 1, 2023
Closed
2 tasks
@MichaelMauderer MichaelMauderer moved this from 📤 Backlog to 🔧 Implementation in Issues Board May 2, 2023
@MichaelMauderer MichaelMauderer mentioned this issue May 2, 2023
Merged
5 tasks
@MichaelMauderer MichaelMauderer moved this from 🔧 Implementation to 👁️ Code review in Issues Board May 2, 2023
@enso-bot
Copy link

enso-bot bot commented May 2, 2023

Michael Mauderer reports a new STANDUP for today (2023-05-02):

Progress: Implemented spinner for visualization. Opened PR. It should be finished by 2023-05-02.

Next Day: Next day I will be working on the #6501 task. Next task.

@enso-bot enso-bot bot mentioned this issue May 8, 2023
Closed
2 tasks
@MichaelMauderer MichaelMauderer moved this from 👁️ Code review to 🌟 Q/A review in Issues Board May 10, 2023
@MichaelMauderer MichaelMauderer moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board May 11, 2023
@mergify mergify bot closed this as completed in #6512 May 12, 2023
mergify bot pushed a commit that referenced this issue May 12, 2023
@MichaelMauderer
Implement loading spinner for visualisations. (#6512)
9e71fea 
Fixes #5088. Adds a ensoGL spinner for visualizations waiting on data.

https://user-images.githubusercontent.com/1428930/236801655-67a0ffed-da5d-4e27-8797-cd8126cb86d9.mp4

# Important Notes
This spinner will not show up for the duration where visualizations are processing data on the frontend. If this is a concern, visualization need to implement heir own loading spinner, or we need to provide a unified API for them to keep the spinner visible.
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelMauderer MichaelMauderer

Labels
-viz p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Issues Board
Archived in project
Milestone
Design Partners
Development

Successfully merging a pull request may close this issue.

Implement loading spinner for visualisations. enso-org/enso
5 participants
@MichaelMauderer @wdanilo @farmaazon @jdunkerley @sylwiabr