Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compression to the metadata code snapshot #11420

Closed
4e6 opened this issue Oct 28, 2024 · 4 comments · Fixed by #11470
Closed

Add compression to the metadata code snapshot #11420

4e6 opened this issue Oct 28, 2024 · 4 comments · Fixed by #11470
Assignees
@4e6
Labels
-gui -language-server

Comments

@4e6
Copy link
Contributor

4e6 commented Oct 28, 2024

Overview

The #11304 adds the ide.snapshot field with the code snapshot to the source file metadata.

Issue

Add compression to the ide.snapshot field. NodeJs has zlib module that provides gzip compression. To use it, we also need to implement appropriate functions for the GraalVM Ydoc server.
@4e6 4e6 self-assigned this Oct 28, 2024
@4e6 4e6 mentioned this issue Oct 28, 2024
Merged
3 tasks
@enso-bot
Copy link

enso-bot bot commented Oct 30, 2024

Dmitry Bushev reports a new STANDUP for today (2024-10-30):

Progress: [10783] Reviving the PR. Updated the branch. Fixed an issue with the access to URL in native-image. Updated the native-image configs. Fixed an issue with the Helidon LoomClient by substituting virtual threads with the platform ones. Undrafted the PR. It should be finished by 2024-11-04.

Next Day: Next day I will be working on the #11420 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Oct 31, 2024

Dmitry Bushev reports a new STANDUP for today (2024-10-31):

Progress: [11420] Started working on the issue. Updated the snapshot logic adding a zlib compression. Tested in gui. Started updating the polyglot ydoc-server. Implemented methods for Buffer. Started working on the zlib compression methods. It should be finished by 2024-11-04.

Next Day: Next day I will be working on the #11420 task. Continue working on the task

@4e6 4e6 mentioned this issue Nov 1, 2024
Merged
3 tasks
@enso-bot
Copy link

enso-bot bot commented Nov 3, 2024

Dmitry Bushev reports a new STANDUP for the provided date (2024-11-01):

Progress: [11420] Implemented the polyfill zlib. Added tests. Changed compression to zlib deflate to reduce the header size. Cleaned up. Created the PR. It should be finished by 2024-11-04.

Next Day: Next day I will be working on the #11420 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Nov 4, 2024

Dmitry Bushev reports a new STANDUP for yesterday (2024-11-04):

Progress: [11420] Working on the review comments. Updated the error handling in the polyfill zlib. Added logging to the snapshot encoding and decoding. Debugging failing native-image build on CI. [11478] Looking into the engine docker build on CI It should be finished by 2024-11-04.

Next Day: Next day I will be working on the #11420 task. Continue working on the task

@mergify mergify bot closed this as completed in #11470 Nov 5, 2024
mergify bot pushed a commit that referenced this issue Nov 5, 2024
@4e6
Add compression to the metadata code snapshot (#11470)
47943a2 
close #11420

Changelog:
- update: add zlib compression to the `snapshot` metadata field
- add: implement nodejs `zlib` for polyglot ydoc-server
- add: implement nodejs `Buffer` for polyglot ydoc-server
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@4e6 4e6

Labels
-gui -language-server
Projects
Issues Board
Status: 🟢 Accepted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add compression to the metadata code snapshot enso-org/enso
1 participant
@4e6