Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Editor Widget - When switching editing between headers, the edit stops. #11150

Open
Tracked by #11183
farmaazon opened this issue Sep 23, 2024 · 8 comments · May be fixed by #12064
Open
Tracked by #11183

Table Editor Widget - When switching editing between headers, the edit stops. #11150

farmaazon opened this issue Sep 23, 2024 · 8 comments · May be fixed by #12064
Assignees
Labels
--bug Type: bug -gui

Comments

@farmaazon
Copy link
Contributor

To reproduce, in any table input widget:

  1. Click at header of some column to edit its name
  2. Without accepting, click another column name

Expected: The previous edit should be accepted, and the next column should be edited.

Actual: The previous edit is accepted, but next column is not edited.

Cause: Accepting column name makes all headers to be re-mounted, so we loose the edit flag

@farmaazon farmaazon added p-medium Should be completed in the next few sprints --bug Type: bug -gui labels Sep 23, 2024
@farmaazon farmaazon added this to the 2024-09 Release milestone Sep 23, 2024
@farmaazon farmaazon self-assigned this Sep 23, 2024
@farmaazon farmaazon removed their assignment Sep 23, 2024
@farmaazon
Copy link
Contributor Author

farmaazon commented Sep 26, 2024

Refinement notes:

  • The information of edited column should be persisted in the widget local state, not in the table header managed by AgGrid.
  • Or maybe we could specify key on Header component, so vue would not re-instantiate it - to verify.
  • Remember to keep selection when restoring - this should be also added to cell editing.

@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Sep 26, 2024
@AdRiley AdRiley changed the title Table Input Widget: when switching editing between headers, the edit stops. Table Editor Widget - When switching editing between headers, the edit stops. Oct 29, 2024
@farmaazon farmaazon self-assigned this Jan 7, 2025
@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jan 9, 2025
@enso-bot
Copy link

enso-bot bot commented Jan 9, 2025

Adam Obuchowicz reports a new STANDUP for yesterday (2025-01-08):

Progress: Managed to fix the issue partially: I see the edit continues, but other things broke in the process (like, there's no selection). It should be finished by 2025-01-15.

Next Day: Next day I will be working on the same task. Fix remaining bugs and refactor Autosized input

@enso-bot
Copy link

enso-bot bot commented Jan 10, 2025

Adam Obuchowicz reports a new STANDUP for yesterday (2025-01-09):

Progress: When debugging, discovered that the headers are re-instantiated way too often - every time anything changes in headerParams for column definition; and that's probably because AGGrid takes a lazy path, and on any paramter change just re-draws the grid. Tried to fix this problem by playing with makeRaw on Refs for header-only configuration. It should be finished by 2025-01-15.

Next Day: Next day I will be working on the same task. Hopefully finish all fixing.

@enso-bot
Copy link

enso-bot bot commented Jan 13, 2025

Adam Obuchowicz reports a new STANDUP for the last Friday (2025-01-10):

Progress: Some part of the day I spent debugging problem with opening projects, and reverting veaury version. Also, helping James with getting code for an expression id. In the task, I change the point where we end editing: from onblur to on pointerdown, because blur is also called when input is detached from dom. It should be finished by 2025-01-15.

Next Day: Next day I will be working on the same task. Make a PR

@enso-bot
Copy link

enso-bot bot commented Jan 14, 2025

Adam Obuchowicz reports a new STANDUP for yesterday (2025-01-13):

Progress: Stuck on the problem with edited input not being auto-selected; investigated the issue. I discovered that adding nextTick fixes the problem, but I don't know why. It should be finished by 2025-01-15.

Next Day: Next day I will be working on the same task. Try to figure out how exactly things works in AgGrid.

@enso-bot
Copy link

enso-bot bot commented Jan 15, 2025

Adam Obuchowicz reports a new STANDUP for yesterday (2025-01-14):

Progress: Progressed a little with next task, but also discovered why nextTick was needed. Had a chat with Paweł about possible solutions and picked one better: modify aggrid-vue so it won't mount vue components by its own, and use our custom teleports instead. Created proof of concept. It should be finished by 2025-01-20.

Next Day: Next day I will be working on the same task. Implement the designed solution.

@enso-bot
Copy link

enso-bot bot commented Jan 15, 2025

Adam Obuchowicz reports a new STANDUP for today (2025-01-15):

Progress: Started with some playing with bazel and investigating a few things; then, implemented a better solution for our problems with AgGridVue. Works surprisingly good, only some issues and clean-ups remains It should be finished by 2025-01-20.

Next Day: Next day I will be working on the same task. Finish the task, this time for good, hopefully

@farmaazon farmaazon removed the p-medium Should be completed in the next few sprints label Jan 16, 2025
@farmaazon farmaazon linked a pull request Jan 16, 2025 that will close this issue
3 tasks
@enso-bot
Copy link

enso-bot bot commented Jan 16, 2025

Adam Obuchowicz reports a new STANDUP for today (2025-01-16):

Progress: Finished refactoring and created a PR It should be finished by 2025-01-20.

Next Day: Next day I will be working on the same task. Apply possible PR comments, and maybe try to improve something. Or go back to "quick edit" task.

@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui
Projects
Status: 👁️ Code review
Development

Successfully merging a pull request may close this issue.

2 participants