-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table Editor Widget - When switching editing between headers, the edit stops. #11150
Comments
Refinement notes:
|
Adam Obuchowicz reports a new STANDUP for yesterday (2025-01-08): Progress: Managed to fix the issue partially: I see the edit continues, but other things broke in the process (like, there's no selection). It should be finished by 2025-01-15. Next Day: Next day I will be working on the same task. Fix remaining bugs and refactor Autosized input |
Adam Obuchowicz reports a new STANDUP for yesterday (2025-01-09): Progress: When debugging, discovered that the headers are re-instantiated way too often - every time anything changes in headerParams for column definition; and that's probably because AGGrid takes a lazy path, and on any paramter change just re-draws the grid. Tried to fix this problem by playing with makeRaw on Refs for header-only configuration. It should be finished by 2025-01-15. Next Day: Next day I will be working on the same task. Hopefully finish all fixing. |
Adam Obuchowicz reports a new STANDUP for the last Friday (2025-01-10): Progress: Some part of the day I spent debugging problem with opening projects, and reverting veaury version. Also, helping James with getting code for an expression id. In the task, I change the point where we end editing: from onblur to on pointerdown, because blur is also called when input is detached from dom. It should be finished by 2025-01-15. Next Day: Next day I will be working on the same task. Make a PR |
Adam Obuchowicz reports a new STANDUP for yesterday (2025-01-13): Progress: Stuck on the problem with edited input not being auto-selected; investigated the issue. I discovered that adding nextTick fixes the problem, but I don't know why. It should be finished by 2025-01-15. Next Day: Next day I will be working on the same task. Try to figure out how exactly things works in AgGrid. |
Adam Obuchowicz reports a new STANDUP for yesterday (2025-01-14): Progress: Progressed a little with next task, but also discovered why nextTick was needed. Had a chat with Paweł about possible solutions and picked one better: modify aggrid-vue so it won't mount vue components by its own, and use our custom teleports instead. Created proof of concept. It should be finished by 2025-01-20. Next Day: Next day I will be working on the same task. Implement the designed solution. |
Adam Obuchowicz reports a new STANDUP for today (2025-01-15): Progress: Started with some playing with bazel and investigating a few things; then, implemented a better solution for our problems with AgGridVue. Works surprisingly good, only some issues and clean-ups remains It should be finished by 2025-01-20. Next Day: Next day I will be working on the same task. Finish the task, this time for good, hopefully |
Adam Obuchowicz reports a new STANDUP for today (2025-01-16): Progress: Finished refactoring and created a PR It should be finished by 2025-01-20. Next Day: Next day I will be working on the same task. Apply possible PR comments, and maybe try to improve something. Or go back to "quick edit" task. |
To reproduce, in any table input widget:
Expected: The previous edit should be accepted, and the next column should be edited.
Actual: The previous edit is accepted, but next column is not edited.
Cause: Accepting column name makes all headers to be re-mounted, so we loose the
edit
flagThe text was updated successfully, but these errors were encountered: