Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race-condition when updating idmap and attaching a visualization #10897

Closed
hubertp opened this issue Aug 27, 2024 · 3 comments · Fixed by #10954
Closed

Race-condition when updating idmap and attaching a visualization #10897

hubertp opened this issue Aug 27, 2024 · 3 comments · Fixed by #10954
Assignees
Labels
-compiler -language-server p-high Should be completed in the next sprint

Comments

@hubertp
Copy link
Collaborator

hubertp commented Aug 27, 2024

Consider a scenario

  1. GUI sends an edit file request, with IdMap containing the id of an expression, say X
  2. GUI sends attach visualization request for X

If visualization request is handled before compilation is triggered, no visualization update will be sent from backend.

@hubertp hubertp added p-high Should be completed in the next sprint -compiler -language-server labels Aug 27, 2024
hubertp added a commit that referenced this issue Aug 27, 2024
Test case for #10883 which revealed problems with visualizations in
issue #10897.
@hubertp
Copy link
Collaborator Author

hubertp commented Aug 27, 2024

Test demonstrating the problem in #10898.

sbt> runtime-integration-tests/testOnly *RuntimeVisualizationsTest -- -z "emit visualization update for the target of a method call (subexpression)"

sometimes it works and sometimes it doesn't, demonstrating the said race-condition.

@enso-bot
Copy link

enso-bot bot commented Aug 30, 2024

Dmitry Bushev reports a new STANDUP for today (2024-08-30):

Progress: [10897] Implemented the fix for the case when there are pending program executions after the EditFileCmd is processed. After reproducing the issue on 10898 branch, found that the actual issue is caused by the fact that UpsertVisualizationJob relies on the fact that the program should be compiled at the moment. Working on the fix It should be finished by 2024-09-06.

Next Day: Next day I will be working on the #10897 task. Continue working on the task

4e6 pushed a commit that referenced this issue Sep 2, 2024
Test case for #10883 which revealed problems with visualizations in
issue #10897.
4e6 pushed a commit that referenced this issue Sep 2, 2024
Test case for #10883 which revealed problems with visualizations in
issue #10897.
@4e6 4e6 moved this from 🔧 Implementation to 👁️ Code review in Issues Board Sep 3, 2024
@enso-bot
Copy link

enso-bot bot commented Sep 3, 2024

Dmitry Bushev reports a new STANDUP for yesterday (2024-09-02):

Progress: [10897] Implemented the execution hooks. Updated visualization logic to clear caches from the hook. Verified that the change fixes the issue on the branch with the reproducer It should be finished by 2024-09-06.

Next Day: Next day I will be working on the #10897 task. Continue working on the task

4e6 pushed a commit that referenced this issue Sep 5, 2024
Test case for #10883 which revealed problems with visualizations in
issue #10897.
mergify bot pushed a commit that referenced this issue Sep 5, 2024
close #10897

Changelog:
- add: implement `RuntimeHooks` to defer some logic until the program execution happens.
@mergify mergify bot closed this as completed in #10954 Sep 5, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Sep 5, 2024
somebody1234 pushed a commit that referenced this issue Sep 8, 2024
close #10897

Changelog:
- add: implement `RuntimeHooks` to defer some logic until the program execution happens.
jdunkerley pushed a commit that referenced this issue Sep 9, 2024
close #10897

Changelog:
- add: implement `RuntimeHooks` to defer some logic until the program execution happens.

(cherry picked from commit 6c80f8f)
jdunkerley pushed a commit that referenced this issue Sep 10, 2024
close #10897

Changelog:
- add: implement `RuntimeHooks` to defer some logic until the program execution happens.

(cherry picked from commit 6c80f8f)
jdunkerley pushed a commit that referenced this issue Sep 10, 2024
close #10897

Changelog:
- add: implement `RuntimeHooks` to defer some logic until the program execution happens.

(cherry picked from commit 6c80f8f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler -language-server p-high Should be completed in the next sprint
Projects
Archived in project
2 participants