-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Race-condition when updating idmap and attaching a visualization #10897
Comments
Test demonstrating the problem in #10898.
sometimes it works and sometimes it doesn't, demonstrating the said race-condition. |
Dmitry Bushev reports a new STANDUP for today (2024-08-30): Progress: [10897] Implemented the fix for the case when there are pending program executions after the EditFileCmd is processed. After reproducing the issue on 10898 branch, found that the actual issue is caused by the fact that UpsertVisualizationJob relies on the fact that the program should be compiled at the moment. Working on the fix It should be finished by 2024-09-06. Next Day: Next day I will be working on the #10897 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for yesterday (2024-09-02): Progress: [10897] Implemented the execution hooks. Updated visualization logic to clear caches from the hook. Verified that the change fixes the issue on the branch with the reproducer It should be finished by 2024-09-06. Next Day: Next day I will be working on the #10897 task. Continue working on the task |
close #10897 Changelog: - add: implement `RuntimeHooks` to defer some logic until the program execution happens.
close #10897 Changelog: - add: implement `RuntimeHooks` to defer some logic until the program execution happens.
Consider a scenario
If visualization request is handled before compilation is triggered, no visualization update will be sent from backend.
The text was updated successfully, but these errors were encountered: