-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify scripts for dashboard and GUI. #10668
Comments
not sure whether this makes sense - the codebases are still significantly different (different frameworks, different architecture an the like) - and idk if there's any advantage in having a more nested structure in this case (two directories in |
other things to note:
|
The advantage is that it's more intuitively reflects the relation between different components. Also, we said about "having a single vite config" and for me it's more natural that vite config handler all things in its subdir. |
Refinement notes:
|
Refinement notes:
|
Adam Obuchowicz reports a new STANDUP for yesterday (2024-10-03): Progress: Started merging directories. Created new structure and merged package.json configurations (and some others). It should be finished by 2024-10-14. Next Day: Next day I will be working on the same task. Continue fixing issues: with packaging, dev server, lint... |
Adam Obuchowicz reports a new STANDUP for today (2024-10-04): Progress: Tried to fix eslint config, with moderate success (we skipped GUI config for vue). Fixed dev server and package building - it works now! started merging playwright configs for tests. It should be finished by 2024-10-14. Next Day: Next day I will be working on the same task. finish playwright and discuss eslint config. |
Adam Obuchowicz reports a new STANDUP for the provided date (2024-10-07): Progress: Fixed playwright configuration. It recognizes now all tests, but the dashboard's are mostly failing. Also moved sligthtly the column reordering. It should be finished by 2024-10-14. Next Day: Next day I will be working on the same task. Fix dashboard tests and start fixing linter configuration. |
Adam Obuchowicz reports a new STANDUP for the last Wednesday (2024-10-09): Progress: Fixed most of the issues with linter - some checks are disabled because fixing them would take too long time. It should be finished by 2024-10-14. Next Day: Next day I will be working on the same task. When testing CI jobs, discovered some problems with typecheck in ide-desktop/client package. |
Adam Obuchowicz reports a new STANDUP for yesterday (2024-10-10): Progress: Fixed the problem in ide-desktop/client. It had a dependency to gui (as formerly it had to dashboard), but it caused problem with project-view codebase. Discovered that it used only one type, so I moved this type to common package. Re-run all checks again, and discovered a regression in E2E tests. It should be finished by 2024-10-14. Next Day: Next day I will be working on the same task. When E-Hern fix e2e tests, I think only last touches remain. |
Adam Obuchowicz reports a new STANDUP for today (2024-10-11): Progress: Last touches. Debugged another package failure (caught by integration tests!) and then stabilize e2e tests (again) - they failed in CI. Also, the flacky test in GUI became very flaky, so I investigated the problem there. The PR is waiting for merge It should be finished by 2024-10-14. Next Day: Next day I will be working on the #10759 task. Go back to reordering columns in Table Input; investigate the issue. |
Now we have two vite configurations and thus two ways of building dev server (and everything else). This task is to unify the configuration (both vite.config and package.json) and stay with a single dev server, run in browser.
In this task also the relation between dashboard and GUI should be simplified: the dashboard should just have GUI as a dependency, and GUI part should not maintain any entry point invoking dashboard.
To consider: having both dashboard and current GUI in a single
app
subdir (ide-desktop
being purely electron).The text was updated successfully, but these errors were encountered: