Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Reopening a Project, no dynamic widgets available. #10595

Closed
jdunkerley opened this issue Jul 18, 2024 · 9 comments · Fixed by #10674
Closed

When Reopening a Project, no dynamic widgets available. #10595

jdunkerley opened this issue Jul 18, 2024 · 9 comments · Fixed by #10674
Assignees
Labels
--regression Important: regression -gui -language-server p-highest Should be completed ASAP

Comments

@jdunkerley
Copy link
Member

The GUI attaches the correct visualizations but no response from the backend of the evaluated json.

Snag_17f6fc27

The simple workflow above works when being built but fails when reopened.

@hubertp
Copy link
Collaborator

hubertp commented Jul 21, 2024

It looks like GUI is not sending executionContext/executeExpression request on startup for the visualization in question. It is also not sending it afterwards. So this is a regression in GUI I think.

@hubertp hubertp added the --regression Important: regression label Jul 21, 2024
@farmaazon
Copy link
Contributor

We do not send executionContext/executeExpression because we send attachVisualization instead.

@hubertp
Copy link
Collaborator

hubertp commented Jul 22, 2024

@farmaazon My bad, sorry about that. We will continue looking into it.

@enso-bot
Copy link

enso-bot bot commented Jul 22, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-07-19):

Progress: More testing of #10579 revealed that a proper fix would be to add retries to GUI. My workaround PR could lead to some unrecoverable "apply edit" loop. Investigating no widgets on startup. Added some more feedback to failing tests (#10608). It should be finished by 2024-07-22.

Next Day: Next day I will be working on the #10595 task. Continue investigating widgets' problem.

@enso-bot
Copy link

enso-bot bot commented Jul 23, 2024

Dmitry Bushev reports a new STANDUP for yesterday (2024-07-22):

Progress: [10595] Picked up the issue. Reproduced the scenario. Fixed an issue with ids cache when adding IdMap to a module. Found the issue with scenario when IdMap added and then visualization is attached to a sub-expression. Started working on the fix. [10542] Fixed failed tests and made the PR ready to merge. It should be finished by 2024-07-26.

Next Day: Next day I will be working on the #10595 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Jul 24, 2024

Dmitry Bushev reports a new STANDUP for yesterday (2024-07-23):

Progress: [10595] Implemented storage for a pending IdMap. Implemented test reproducing issue for attaching visualization to sub-expression after applying the IdMap. Debugging attaching visualization to sub-expression feature. It should be finished by 2024-07-26.

Next Day: Next day I will be working on the #10595 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Jul 24, 2024

Dmitry Bushev reports a new STANDUP for today (2024-07-24):

Progress: [10656] Added more accurate logging for engine locking logic. [10595] Fixed the test case. Testing the scenario in gui. It should be finished by 2024-07-26.

Next Day: Next day I will be working on the #10595 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Jul 24, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-07-22):

Progress: Debugging together with Dmitry lack of widgets. Once he found the real culprit, a PR with a revert was created (#10626). Dealing with some random CI failures, not yet sure what's happening. Made Ydoc initialization in backend optional (#10627). Resurrecting soft delete PR with Jaroslav's patches. It should be finished by 2024-07-26.

Next Day: Next day I will be working on the #10595 task. Continue with soft delete issue and projects in subfolders downloading issues.

mergify bot pushed a commit that referenced this issue Jul 25, 2024
related: #10595

Locking log message now always includes the caller class.
@enso-bot
Copy link

enso-bot bot commented Jul 25, 2024

Dmitry Bushev reports a new STANDUP for today (2024-07-25):

Progress: [10595] Implemented updating external IDs after the module is loaded from cache. Simplified the cache invalidation logic when the visualization is attached to subexpression. Fixed the tests. Tested in GUI. Created the PR [10674] It should be finished by 2024-07-26.

Next Day: Next day I will be working on the #10595 task. Continue working on the task

@mergify mergify bot closed this as completed in #10674 Jul 27, 2024
@mergify mergify bot closed this as completed in 9e19009 Jul 27, 2024
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--regression Important: regression -gui -language-server p-highest Should be completed ASAP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants