Comparable.from doesn't return Comparable

[JaroslavTulach]

• Opt-in return type checks #8502 implemented a way to check return type of a function.

Alas, conversion methods are not checked right now, because Comparable.from typically violates the required contract - it doesn't return Comparable, but some unrelated type.

The goal of this issue is to change the way we deal with Comparable and turn on the return type check for conversion methods.

type Comparable
    private Both value:Any comparator:Any
    
    new value:Any comparator:Any -> Comparable = Comparable.Both value comparator

    // implement operations by using self.value and that.value and delegating to self.comparator
    <,>,>=,<=,=

• Verify the extra abstraction doesn't influence benchmarks.
• Turn return type check on: patch is here

[JaroslavTulach]

This is the code that enables return type check for conversion methods:

diff --git engine/runtime-integration-tests/src/test/java/org/enso/compiler/ExecCompilerTest.java engine/runtime-integration-tests/src/test/java/org/enso/compiler/ExecCompilerTest.java
index c194132011..ad4ea01208 100644
--- engine/runtime-integration-tests/src/test/java/org/enso/compiler/ExecCompilerTest.java
+++ engine/runtime-integration-tests/src/test/java/org/enso/compiler/ExecCompilerTest.java
@@ -21,6 +21,7 @@ import org.graalvm.polyglot.Context;
 import org.graalvm.polyglot.PolyglotException;
 import org.graalvm.polyglot.Source;
 import org.graalvm.polyglot.io.IOAccess;
+import org.hamcrest.core.AllOf;
 import org.junit.AfterClass;
 import org.junit.BeforeClass;
 import org.junit.Ignore;
@@ -478,4 +479,30 @@ public class ExecCompilerTest {
     runMethod.execute(0);
     assertThat(out.toString(), containsString(expectedErrMsg));
   }
+
+  @Test
+  public void resultOfConversionIsTypeChecked() throws Exception {
+    var module =
+        ctx.eval(
+            LanguageInfo.ID,
+            """
+        type First_Type
+        type Other_Type
+
+        First_Type.from (that:Other_Type) = 42
+        run value -> First_Type = Other_Type
+        """);
+    var runMethod = module.invokeMember(Module.EVAL_EXPRESSION, "run");
+    try {
+      var r = runMethod.execute(0);
+      fail("We don't expect any result, but exception: " + r);
+    } catch (PolyglotException ex) {
+      assertThat(
+          ex.getMessage().toLowerCase(),
+          AllOf.allOf(containsString("type"), containsString("error")));
+      var typeError = ex.getGuestObject();
+      assertEquals("Expected type", "First_Type", typeError.getMember("expected").toString());
+      assertEquals("Got wrong value", 42, typeError.getMember("actual").asInt());
+    }
+  }
 }
diff --git engine/runtime/src/main/scala/org/enso/interpreter/runtime/IrToTruffle.scala engine/runtime/src/main/scala/org/enso/interpreter/runtime/IrToTruffle.scala
index fc6ddf9f78..606c839864 100644
--- engine/runtime/src/main/scala/org/enso/interpreter/runtime/IrToTruffle.scala
+++ engine/runtime/src/main/scala/org/enso/interpreter/runtime/IrToTruffle.scala
@@ -504,6 +504,7 @@ class IrToTruffle(
                             m.getFunction.getName,
                             fn.arguments,
                             fn.body,
+                            null,
                             effectContext,
                             true
                           )
@@ -536,6 +537,7 @@ class IrToTruffle(
                     fullMethodDefName,
                     fn.arguments,
                     fn.body,
+                    null,
                     effectContext,
                     true
                   )
@@ -712,6 +714,7 @@ class IrToTruffle(
                 methodDef.methodName.name,
                 fn.arguments,
                 fn.body,
+                ReadArgumentCheckNode.build(context, "conversion", toType),
                 None,
                 true
               )
@@ -1921,6 +1924,7 @@ class IrToTruffle(
       val initialName: String,
       val arguments: List[DefinitionArgument],
       val body: Expression,
+      val typeCheck: ReadArgumentCheckNode,
       val effectContext: Option[String],
       val subjectToInstrumentation: Boolean
     ) {
@@ -1949,7 +1953,13 @@ class IrToTruffle(
           case _ =>
             ExpressionProcessor.this.run(body, false, subjectToInstrumentation)
         }
-        (argExpressions.toArray, bodyExpr)
+
+        if (typeCheck == null) {
+          (argExpressions.toArray, bodyExpr)
+        } else {
+          val bodyWithCheck = ReadArgumentCheckNode.wrap(bodyExpr, typeCheck)
+          (argExpressions.toArray, bodyWithCheck)
+        }
       }
 
       private def computeSlots(): (
@@ -2039,7 +2049,7 @@ class IrToTruffle(
       binding: Boolean = false
     ): CreateFunctionNode = {
       val bodyBuilder =
-        new BuildFunctionBody(scopeName, arguments, body, None, false)
+        new BuildFunctionBody(scopeName, arguments, body, null, None, false)
       val fnRootNode = ClosureRootNode.build(
         language,
         scope,

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2024-07-08):

Progress: - Fixing #10355 with #10468
- down to 33 failures: #10468 (comment)
- reported ensoup issue: #10476
- review of autoscoped First/Last: #10467 (review)
- review of shapeless: #10462 (review)
- closed eta-conversion: #10281 (comment)
- demo meetings
- standup
- meeting Dmitry It should be finished by 2024-07-12.

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2024-07-09):

Progress: - analyzing benchmarks: #10468 (comment)

• various ways to define Ordering.compare: 091b0fd
• review withContextLock: Fix context lock removal #10273 (comment)
• two failures in EqualsConversionsTest: 2ae4514
• Fixed benchmarks: f5f1b91
• Fixing MetaObjectPolyglotTest for James
• Standard.Test & runEngineDistribution PR: Support re-running failed tests with runEngineDistribution #10483
• Planning meeting
• libs standup
• discussion with Greg: Adding type annotations and enabling auto-scoping #10173 (comment) It should be finished by 2024-07-12.

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2024-07-10):

Progress: - checking benchmarks results: #10468 (comment)

• re-running tests PR merged: Support re-running failed tests with runEngineDistribution #10483
• Opaque Comparable type: f2efc5c
• documenting API: ecfcece
• missing @specialization for BigInteger: a2c4def
• Fixing Investigate slow opening of a project having large CSV file #10503 regression by Speed up EnsoInputStream again #10515
• review of JNA trash: Soft delete projects by moving them to trash #10440 (review)
• reviewing: Replace all from ... export all with explicit exports #10369 (comment)
• standups and meetings It should be finished by 2024-07-12.

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2024-07-11):

Progress: - Merged: #10468

• Merged EnsoInputStream: Speed up EnsoInputStream again #10515
• discusing RuntimeCache with Hubert: https://discord.com/channels/@me/959434339182067712/1260954382535495743
• Compiler Error reproduced & passed to Kaz: Compiler Internal Error: Impossible here, static method get should be caught when translating application #10473 (comment)
• Working on Avoid name duplication of the enso universal launcher #10476 by creating: Renaming launcher executable to ensoup #10535
• language-server loosely PR: engine-runner shall not depend on language-server #10536 It should be finished by 2024-07-12.

Discord

Discord - Group Chat That’s All Fun & Games

Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2024-07-12):

Progress: - reported benchmarks regression issue: #10539

• language-server "inversion of dependencies" PR merged: engine-runner shall not depend on language-server #10536
• running nightly ensoup release: Renaming launcher executable to ensoup #10535 (comment)
• making MacOSX jobs required? https://discord.com/channels/@me/948519891961544714/1261225312667303948
• measuring effect of import/export: https://discord.com/channels/@me/1010161953634791434/1261278426422313033
• discussing from: Ability to get a list of target conversion #10545 (comment) It should be finished by 2024-07-12.

Discord

Discord - Group Chat That’s All Fun & Games

Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

Discord

Discord - Group Chat That’s All Fun & Games

Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.