-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to rename a project from inside the graph editor #10073
Comments
It seems we may use |
@AdRiley or @jdunkerley what interaction should start editing the project name? The click already navigates the breadcrumbs. Should it be Alt/Ctrl + click, or double click? |
Both of those feel hidden. What do we think of a small rename icon? Or if you are already "home" then clicking allows rename? |
I can start with rename icon, it's most obvious. |
So I've made an initial implementation on branch The exchange is a bit strange:
And these are engine's responses:
So far, so good.
But here we've received an "update" with new name being actually an old name.
Here we see the entries with old name back.
But here the |
Yes, looks like an issue with visible name/normalize name usage. I'll look into it |
Adam Obuchowicz reports a new STANDUP for yesterday (2024-06-06): Progress: Implemented the feature using "rename" button - perhaps still some styling is needed. Tested with engine, and reported all problems I have. It should be finished by 2024-06-10. Next Day: Next day I will be working on the same task. Work with Dmitry to fix all engine issues. |
About the second issue with calling the I think it is possible to update the
TLDR, if I didn't miss anything, it should be possible to make the |
Adam Obuchowicz reports a new STANDUP for the last Friday (2024-06-07): Progress: Checked fixes from the engine, but it does not work properly still. Discussed how to handle those issues - as it turns out, I need to use PM endpoint for renaming project. Read a bit about lexical. It should be finished by 2024-06-10. Next Day: Next day I will be working on the same task. implement the renaming as discussed with Dmitry. |
I think this should be eventually done, but because I can quite easily (I hope) implement calling PM for renaming project, this is not high priority. |
Adam Obuchowicz reports a new 🔴 DELAY for today (2024-06-10): Summary: There is 4 days delay in implementation of the Add the ability to rename a project from inside the graph editor (#10073) task. Delay Cause: I discovered how to use engine's API only in action. Also I touched the dashboard code, so I expect a bit longer review on that. |
Adam Obuchowicz reports a new STANDUP for today (2024-06-10): Progress: Did a simple implementation of calling PM endpoint for renaming project. There was an issue with our representation of execution context. Implemented an update, but still there are some issues. It should be finished by 2024-06-14. Next Day: Next day I will be working on the same task. Fix issues, and hopefully make a PR. |
Engine team believe all works on their side
The text was updated successfully, but these errors were encountered: