Make sure setExpressionUnsync is called all the time

enso-org · Sep 23, 2022 · ee488ae · ee488ae
1 parent aedd98e
commit ee488ae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...ent-id-execution/src/main/java/org/enso/interpreter/instrument/IdExecutionInstrument.java b/...ent-id-execution/src/main/java/org/enso/interpreter/instrument/IdExecutionInstrument.java
@@ -186,12 +186,11 @@ public void onReturnValue(EventContext context, VirtualFrame frame, Object resul
         FunctionCallInfo cachedCall = cache.getCall(nodeId);
         ProfilingInfo[] profilingInfo = new ProfilingInfo[] {new ExecutionTime(nanoTimeElapsed)};
 
+        System.out.println("onReturnValue " + nodeId + " value: " + result + " type: " + resultType);
         ExpressionValue expressionValue =
             new ExpressionValue(
                 nodeId, result, resultType, cachedType, call, cachedCall, profilingInfo, false);
-        if (expressionValue.isTypeChanged() || expressionValue.isFunctionCallChanged()) {
-          syncState.setExpressionUnsync(nodeId);
-        }
+        syncState.setExpressionUnsync(nodeId);
         syncState.setVisualisationUnsync(nodeId);
 
         // Panics are not cached because a panic can be fixed by changing seemingly unrelated code,

diff --git a/engine/runtime/src/main/scala/org/enso/interpreter/instrument/job/EnsureCompiledJob.scala b/engine/runtime/src/main/scala/org/enso/interpreter/instrument/job/EnsureCompiledJob.scala
@@ -325,10 +325,12 @@ final class EnsureCompiledJob(protected val files: Iterable[File])
         val knownKeys   = stack.top.cache.getWeights.entrySet
         val cachedKeys  = stack.top.cache.getKeys
         val pendingKeys = new java.util.HashSet[UUID]()
+
         knownKeys.forEach(e => {
           if (e.getValue > 0) {
             if (!cachedKeys.contains(e.getKey)) {
               pendingKeys.add(e.getKey)
+              System.out.println("  found key with " + e.getValue + " key: " + e.getKey)
             }
           }
         });