Merge branch 'develop' into wip/hubert/copying-opt

.github/workflows/gui-tests.yml

@@ -1,7 +1,7 @@
 # This file is auto-generated. Do not edit it manually!
 # Edit the enso_build::ci_gen module instead and run `cargo run --package enso-build-ci-gen`.
 
-name: GUI Tests
+name: GUI Check
 on:
   push:
     branches:
@@ -27,7 +27,7 @@ jobs:
           access_token: ${{ github.token }}
     permissions:
       actions: write
-  enso-build-ci-gen-job-gui-test-linux-x86_64:
+  enso-build-ci-gen-job-gui-check-linux-x86_64:
     name: GUI tests (linux, x86_64)
     runs-on:
       - self-hosted
@@ -56,7 +56,7 @@ jobs:
         run: ./run git-clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - run: ./run gui test
+      - run: ./run gui check
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - if: failure() && runner.os == 'Windows'

.github/workflows/gui.yml

@@ -155,7 +155,7 @@ jobs:
           access_token: ${{ github.token }}
     permissions:
       actions: write
-  enso-build-ci-gen-job-new-gui-build-linux-x86_64:
+  enso-build-ci-gen-job-gui-build-linux-x86_64:
     name: GUI build (linux, x86_64)
     runs-on:
       - self-hosted
@@ -210,7 +210,7 @@ jobs:
         run: ./run git-clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  enso-build-ci-gen-job-new-gui-build-macos-x86_64:
+  enso-build-ci-gen-job-gui-build-macos-x86_64:
     name: GUI build (macos, x86_64)
     runs-on:
       - macos-12
@@ -264,7 +264,7 @@ jobs:
         run: ./run git-clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  enso-build-ci-gen-job-new-gui-build-windows-x86_64:
+  enso-build-ci-gen-job-gui-build-windows-x86_64:
     name: GUI build (windows, x86_64)
     runs-on:
       - self-hosted

.gitignore

@@ -73,6 +73,8 @@ node_modules/
 .metals
 tools/performance/engine-benchmarks/generated_site
 *.tsbuildinfo
+vite.config.ts.timestamp-*.mjs
+vitest.config.ts.timestamp-*.mjs
 
 ############################
 ## Rendered Documentation ##

.pnpmfile.cjs

@@ -0,0 +1,21 @@
+const IGNORED_DEPS = ['react-native-url-polyfill', 'react-native-get-random-values']
+
+const unusedIgnores = new Set(IGNORED_DEPS)
+module.exports.hooks = {
+  readPackage: (pkg, context) => {
+    for (const ignored of IGNORED_DEPS) {
+      if (pkg.dependencies[ignored]) {
+        delete pkg.dependencies[ignored]
+        context.log(`Ignoring dependency ${ignored} in ${pkg.name}`)
+        unusedIgnores.delete(ignored)
+      }
+    }
+    return pkg
+  },
+  afterAllResolved(lockfile, context) {
+    if (unusedIgnores.size > 0) {
+      context.log(`Unused dependency ignore declarations: ${Array.from(unusedIgnores).join(', ')}`)
+    }
+    return lockfile
+  },
+}

.prettierignore

@@ -38,8 +38,7 @@ app/ide-desktop/lib/dashboard/playwright-report/
 app/ide-desktop/lib/dashboard/playwright/.cache/
 app/ide-desktop/lib/dashboard/dist/
 app/gui/view/documentation/assets/stylesheet.css
-app/gui2/rust-ffi/pkg
-app/gui2/rust-ffi/node-pkg
+app/rust-ffi/pkg
 app/gui2/src/assets/font-*.css
 Cargo.lock
 build.json

CHANGELOG.md

@@ -1,14 +1,24 @@
 # Next Release
 
+#### Enso IDE
+
+- [Table Editor Widget][10774] displayed in `Table.new` component.
+
+[10774]: https://github.com/enso-org/enso/pull/10774
+
 #### Enso Standard Library
 
 - [Implemented in-memory and database mixed `Decimal` column
   comparisons.][10614]
 - [Relative paths are now resolved relative to the project location, also in the
   Cloud.][10660]
+- [Added Newline option to Text_Cleanse/Text_Replace.][10761]
+- [Support for reading from Tableau Hyper files.][10733]
 
 [10614]: https://github.com/enso-org/enso/pull/10614
 [10660]: https://github.com/enso-org/enso/pull/10660
+[10761]: https://github.com/enso-org/enso/pull/10761
+[10733]: https://github.com/enso-org/enso/pull/10733
 
 # Enso 2023.3
 
@@ -18,11 +28,13 @@
 - [Renaming launcher executable to ensoup][10535]
 - [Space-precedence does not apply to value-level operators][10597]
 - [Must specify `--repl` to enable debug server][10709]
+- [Improved parser error reporting and performance][10734]
 
 [10468]: https://github.com/enso-org/enso/pull/10468
 [10535]: https://github.com/enso-org/enso/pull/10535
 [10597]: https://github.com/enso-org/enso/pull/10597
 [10709]: https://github.com/enso-org/enso/pull/10709
+[10734]: https://github.com/enso-org/enso/pull/10734
 
 #### Enso IDE
 

Cargo.toml

@@ -7,7 +7,7 @@ resolver = "2"
 # path, e.g. `lib/rust/ensogl/examples`, or `app/gui/view/examples`; this is used to optimize the application for
 # loading the IDE.
 members = [
-    "app/gui2/rust-ffi",
+    "app/rust-ffi",
     "build/cli",
     "build/macros/proc-macro",
     "build/ci-gen",
@@ -23,6 +23,7 @@ members = [
     "lib/rust/parser/generate-java",
     "lib/rust/parser/schema",
     "lib/rust/parser/debug",
+    "lib/rust/parser/debug/fuzz",
     "tools/language-server/logstat",
     "tools/language-server/wstest",
 ]
@@ -47,6 +48,11 @@ incremental = true
 debug = false
 debug-assertions = false
 
+[profile.fuzz]
+inherits = "release"
+debug-assertions = true
+overflow-checks = true
+
 [profile.bench]
 opt-level = 3
 lto = true

app/.example.env

@@ -8,3 +8,5 @@ ENSO_CLOUD_AMPLIFY_USER_POOL_ID=mars_AAAAAAAAA
 ENSO_CLOUD_AMPLIFY_USER_POOL_WEB_CLIENT_ID=zzzzzzzzzzzzzzzzzzzzzzzzzz
 ENSO_CLOUD_AMPLIFY_DOMAIN=somewhere.auth.mars.amazoncognito.com
 ENSO_CLOUD_AMPLIFY_REGION=mars
+ENSO_POLYGLOT_YDOC_SERVER=false
+ENSO_YDOC_LS_DEBUG=false

app/.vscode/react.code-snippets

@@ -2,9 +2,6 @@
   "React Component": {
     "prefix": ["$c", "component"],
     "body": [
-      "/** @file $2 */",
-      "import * as React from 'react'",
-      "",
       "// ====${1/./=/g}====",
       "// === $1 ===",
       "// ====${1/./=/g}====",
@@ -18,15 +15,28 @@
       "export default function $1(props: $1Props) {",
       "  const { ${3/(.+?):.+/$1, /g} } = props",
       "  return <>$4</>",
-      "}"
-    ]
+      "}",
+    ],
+  },
+  "React Hook": {
+    "prefix": ["$h", "hook"],
+    "body": [
+      "// =======${1/./=/g}====",
+      "// === use$1 ===",
+      "// =======${1/./=/g}====",
+      "",
+      "/** $2 */",
+      "export function use$1($3) {",
+      "  $4",
+      "}",
+    ],
   },
   "useState": {
     "prefix": ["$s", "usestate"],
-    "body": ["const [$1, set${1/(.*)/${1:/pascalcase}/}] = React.useState($2)"]
+    "body": ["const [$1, set${1/(.*)/${1:/pascalcase}/}] = React.useState($2)"],
   },
   "section": {
     "prefix": ["$S", "section"],
-    "body": ["// ====${1/./=/g}====", "// === $1 ===", "// ====${1/./=/g}===="]
-  }
+    "body": ["// ====${1/./=/g}====", "// === $1 ===", "// ====${1/./=/g}===="],
+  },
 }

app/dashboard/e2e/README.md

@@ -6,20 +6,20 @@ Execute all commands from the parent directory.
 
 ```sh
 # Run tests normally
-npm run test:e2e
+pnpm run test:e2e
 # Open UI to run tests
-npm run test:e2e:debug
+pnpm run test:e2e:debug
 # Run tests in a specific file only
-npm run test:e2e -- e2e/file-name-here.spec.ts
-npm run test:e2e:debug -- e2e/file-name-here.spec.ts
+pnpm run test:e2e -- e2e/file-name-here.spec.ts
+pnpm run test:e2e:debug -- e2e/file-name-here.spec.ts
 # Compile the entire app before running the tests.
 # DOES NOT hot reload the tests.
 # Prefer not using this when you are trying to fix a test;
 # prefer using this when you just want to know which tests are failing (if any).
-PROD=1 npm run test:e2e
-PROD=1 npm run test:e2e:debug
-PROD=1 npm run test:e2e -- e2e/file-name-here.spec.ts
-PROD=1 npm run test:e2e:debug -- e2e/file-name-here.spec.ts
+PROD=1 pnpm run test:e2e
+PROD=1 pnpm run test:e2e:debug
+PROD=1 pnpm run test:e2e -- e2e/file-name-here.spec.ts
+PROD=1 pnpm run test:e2e:debug -- e2e/file-name-here.spec.ts
 ```
 
 ## Getting started

app/dashboard/e2e/actions.ts

@@ -225,7 +225,7 @@ export function locateNotEnabledStub(page: test.Locator | test.Page) {
 
 /** Find a "new folder" icon (if any) on the current page. */
 export function locateNewFolderIcon(page: test.Locator | test.Page) {
-  return page.getByRole('button', { name: 'New Folder' })
+  return page.getByRole('button', { name: 'New Folder', exact: true })
 }
 
 /** Find a "new secret" icon (if any) on the current page. */
@@ -325,7 +325,12 @@ export function locateAssetsTable(page: test.Page) {
 
 /** Find assets table rows (if any) on the current page. */
 export function locateAssetRows(page: test.Page) {
-  return locateAssetsTable(page).locator('tbody').getByRole('row')
+  return locateAssetsTable(page).getByTestId('asset-row')
+}
+
+/** Find assets table placeholder rows (if any) on the current page. */
+export function locateNonAssetRows(page: test.Page) {
+  return locateAssetsTable(page).locator('tbody tr:not([data-testid="asset-row"])')
 }
 
 /** Find the name column of the given asset row. */