Skip to content

Commit

Permalink
fixes, test uncertainty
Browse files Browse the repository at this point in the history
  • Loading branch information
radeusgd committed Jan 14, 2023
1 parent b43074c commit 131d4a7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ type Storage
Storage.Integer -> Java_Storage.Type.LONG
Storage.Decimal -> Java_Storage.Type.DOUBLE
Storage.Text -> Java_Storage.Type.STRING
Storage.Boolean -> Java_Storage.Type.BOOLEAN
Storage.Boolean -> Java_Storage.Type.BOOL
Storage.Date -> Java_Storage.Type.DATE
Storage.Time_Of_Day -> Java_Storage.Type.TIME_OF_DAY
Storage.Date_Time -> Java_Storage.Type.DATE_TIME
Expand Down
6 changes: 3 additions & 3 deletions test/Table_Tests/src/Common_Table_Operations/Union_Spec.enso
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,8 @@ spec setup =
t3.at "B" . value_type . should_equal Value_Type.Float

Test.specify "if type widening is not allowed and types do not match, should report error and drop the problematic column" <|
t1 = table_builder [["A", [1, 2, 3]], ["B", [1.5, 2.5, 3.5]], ["C", [True, False, Nothing]], ["D", [10, 20, 30]]]
t2 = table_builder [["A", [4, 5, 6]], ["B", [1, 2, 3]], ["C", [1, 2, 3]], ["D", [True, True, True]]]
t1 = table_builder [["A", [1, 2, 3]], ["B", [1, 2, 3]], ["C", [True, False, Nothing]], ["D", [10, 20, 30]]]
t2 = table_builder [["A", [4, 5, 6]], ["B", [1.5, 2.5, 3.5]], ["C", [1, 2, 3]], ["D", [True, True, True]]]

t1.at "B" . value_type . should_equal Value_Type.Float
t1.at "C" . value_type . should_equal Value_Type.Boolean
Expand All @@ -259,7 +259,7 @@ spec setup =
t2.at "C" . value_type . should_equal Value_Type.Integer
t2.at "D" . value_type . should_equal Value_Type.Boolean

action = t2.union t1 on_problems=_
action = t1.union t2 allow_type_widening=False on_problems=_
tester table =
expect_column_names ["A"] table
table.at "A" . to_vector . should_equal [4, 5, 6, 1, 2, 3]
Expand Down

0 comments on commit 131d4a7

Please sign in to comment.