-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for OwnedResolver #280
Open
subashcs
wants to merge
2
commits into
ensdomains:dev
Choose a base branch
from
subashcs:test/owned-resolver-updates
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,213 @@ | ||
| const ENS = artifacts.require('./registry/ENSRegistry.sol') | ||
| const OwnedResolver = artifacts.require('OwnedResolver.sol') | ||
| const NameWrapper = artifacts.require('DummyNameWrapper.sol') | ||
| const { deploy } = require('../test-utils/contracts') | ||
| const { labelhash } = require('../test-utils/ens') | ||
| const { EMPTY_BYTES32: ROOT_NODE } = require('../test-utils/constants') | ||
|
|
||
| const namehash = require('eth-ens-namehash') | ||
| const sha3 = require('web3-utils').sha3 | ||
|
|
||
| const { | ||
| exceptions, | ||
| dns: { nameToHex }, | ||
| } = require('../test-utils') | ||
|
|
||
| contract('OwnedResolver', function (accounts) { | ||
| let node | ||
| let ens, resolver, nameWrapper | ||
| let account | ||
| let signers | ||
|
|
||
| beforeEach(async () => { | ||
| signers = await ethers.getSigners() | ||
| account = await signers[0].getAddress() | ||
| node = namehash.hash('eth') | ||
| ens = await ENS.new() | ||
| nameWrapper = await NameWrapper.new() | ||
|
|
||
| //setup reverse registrar | ||
|
|
||
| const ReverseRegistrar = await deploy('ReverseRegistrar', ens.address) | ||
|
|
||
| await ens.setSubnodeOwner(ROOT_NODE, labelhash('reverse'), account) | ||
| await ens.setSubnodeOwner( | ||
| namehash.hash('reverse'), | ||
| labelhash('addr'), | ||
| ReverseRegistrar.address, | ||
| ) | ||
|
|
||
| resolver = await OwnedResolver.new( | ||
| ens.address, | ||
| nameWrapper.address, | ||
| accounts[9], // trusted contract | ||
| ReverseRegistrar.address, //ReverseRegistrar.address, | ||
| ) | ||
|
|
||
| await ReverseRegistrar.setDefaultResolver(resolver.address) | ||
|
|
||
| await ens.setSubnodeOwner('0x0', sha3('eth'), accounts[0], { | ||
| from: accounts[0], | ||
| }) | ||
| }) | ||
|
|
||
| describe('dns', async () => { | ||
| const basicSetDNSRecords = async () => { | ||
| // a.eth. 3600 IN A 1.2.3.4 | ||
| const arec = '016103657468000001000100000e10000401020304' | ||
| // b.eth. 3600 IN A 2.3.4.5 | ||
| const b1rec = '016203657468000001000100000e10000402030405' | ||
| // b.eth. 3600 IN A 3.4.5.6 | ||
| const b2rec = '016203657468000001000100000e10000403040506' | ||
| // eth. 86400 IN SOA ns1.ethdns.xyz. hostmaster.test.eth. 2018061501 15620 1800 1814400 14400 | ||
| const soarec = | ||
| '03657468000006000100015180003a036e733106657468646e730378797a000a686f73746d6173746572057465737431036574680078492cbd00003d0400000708001baf8000003840' | ||
| const rec = '0x' + arec + b1rec + b2rec + soarec | ||
|
|
||
| await resolver.setDNSRecords(node, rec, { from: accounts[0] }) | ||
|
|
||
| assert.equal( | ||
| await resolver.dnsRecord(node, sha3(nameToHex('a.eth.')), 1), | ||
| '0x016103657468000001000100000e10000401020304', | ||
| ) | ||
| assert.equal( | ||
| await resolver.dnsRecord(node, sha3(nameToHex('b.eth.')), 1), | ||
| '0x016203657468000001000100000e10000402030405016203657468000001000100000e10000403040506', | ||
| ) | ||
| assert.equal( | ||
| await resolver.dnsRecord(node, sha3(nameToHex('eth.')), 6), | ||
| '0x03657468000006000100015180003a036e733106657468646e730378797a000a686f73746d6173746572057465737431036574680078492cbd00003d0400000708001baf8000003840', | ||
| ) | ||
| } | ||
| it('permits setting name by owner', basicSetDNSRecords) | ||
|
|
||
| it('should keep track of entries', async () => { | ||
| // c.eth. 3600 IN A 1.2.3.4 | ||
| const crec = '016303657468000001000100000e10000401020304' | ||
| const rec = '0x' + crec | ||
|
|
||
| await resolver.setDNSRecords(node, rec, { from: accounts[0] }) | ||
|
|
||
| // Initial check | ||
| let hasEntries = await resolver.hasDNSRecords( | ||
| node, | ||
| sha3(nameToHex('c.eth.')), | ||
| ) | ||
| assert.equal(hasEntries, true) | ||
| hasEntries = await resolver.hasDNSRecords(node, sha3(nameToHex('d.eth.'))) | ||
| assert.equal(hasEntries, false) | ||
|
|
||
| // Update with no new data makes no difference | ||
| await resolver.setDNSRecords(node, rec, { from: accounts[0] }) | ||
| hasEntries = await resolver.hasDNSRecords(node, sha3(nameToHex('c.eth.'))) | ||
| assert.equal(hasEntries, true) | ||
|
|
||
| // c.eth. 3600 IN A | ||
| const crec2 = '016303657468000001000100000e100000' | ||
| const rec2 = '0x' + crec2 | ||
|
|
||
| await resolver.setDNSRecords(node, rec2, { from: accounts[0] }) | ||
|
|
||
| // Removal returns to 0 | ||
| hasEntries = await resolver.hasDNSRecords(node, sha3(nameToHex('c.eth.'))) | ||
| assert.equal(hasEntries, false) | ||
| }) | ||
|
|
||
| it('forbids setting DNS records by non-owners', async () => { | ||
| // f.eth. 3600 IN A 1.2.3.4 | ||
| const frec = '016603657468000001000100000e10000401020304' | ||
| const rec = '0x' + frec | ||
| await exceptions.expectFailure( | ||
| resolver.setDNSRecords(node, rec, { from: accounts[1] }), | ||
| ) | ||
| }) | ||
|
|
||
| const basicSetZonehash = async () => { | ||
| await resolver.setZonehash( | ||
| node, | ||
| '0x0000000000000000000000000000000000000000000000000000000000000001', | ||
| { from: accounts[0] }, | ||
| ) | ||
| assert.equal( | ||
| await resolver.zonehash(node), | ||
| '0x0000000000000000000000000000000000000000000000000000000000000001', | ||
| ) | ||
| } | ||
|
|
||
| it('permits setting zonehash by owner', basicSetZonehash) | ||
|
|
||
| it('can overwrite previously set zonehash', async () => { | ||
| await resolver.setZonehash( | ||
| node, | ||
| '0x0000000000000000000000000000000000000000000000000000000000000001', | ||
| { from: accounts[0] }, | ||
| ) | ||
| assert.equal( | ||
| await resolver.zonehash(node), | ||
| '0x0000000000000000000000000000000000000000000000000000000000000001', | ||
| ) | ||
|
|
||
| await resolver.setZonehash( | ||
| node, | ||
| '0x0000000000000000000000000000000000000000000000000000000000000002', | ||
| { from: accounts[0] }, | ||
| ) | ||
| assert.equal( | ||
| await resolver.zonehash(node), | ||
| '0x0000000000000000000000000000000000000000000000000000000000000002', | ||
| ) | ||
| }) | ||
|
|
||
| it('can overwrite to same zonehash', async () => { | ||
| await resolver.setZonehash( | ||
| node, | ||
| '0x0000000000000000000000000000000000000000000000000000000000000001', | ||
| { from: accounts[0] }, | ||
| ) | ||
| assert.equal( | ||
| await resolver.zonehash(node), | ||
| '0x0000000000000000000000000000000000000000000000000000000000000001', | ||
| ) | ||
|
|
||
| await resolver.setZonehash( | ||
| node, | ||
| '0x0000000000000000000000000000000000000000000000000000000000000002', | ||
| { from: accounts[0] }, | ||
| ) | ||
| assert.equal( | ||
| await resolver.zonehash(node), | ||
| '0x0000000000000000000000000000000000000000000000000000000000000002', | ||
| ) | ||
| }) | ||
|
|
||
| it('forbids setting zonehash by non-owners', async () => { | ||
| await exceptions.expectFailure( | ||
| resolver.setZonehash( | ||
| node, | ||
| '0x0000000000000000000000000000000000000000000000000000000000000001', | ||
| { from: accounts[1] }, | ||
| ), | ||
| ) | ||
| }) | ||
|
|
||
| it('forbids writing same zonehash by non-owners', async () => { | ||
| await resolver.setZonehash( | ||
| node, | ||
| '0x0000000000000000000000000000000000000000000000000000000000000001', | ||
| { from: accounts[0] }, | ||
| ) | ||
|
|
||
| await exceptions.expectFailure( | ||
| resolver.setZonehash( | ||
| node, | ||
| '0x0000000000000000000000000000000000000000000000000000000000000001', | ||
| { from: accounts[1] }, | ||
| ), | ||
| ) | ||
| }) | ||
|
|
||
| it('returns empty when fetching nonexistent zonehash', async () => { | ||
| assert.equal(await resolver.zonehash(node), null) | ||
| }) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of rewriting this instead of using
dnsName?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the question @Arachnid. Actually, the "dnsName" function is renamed to the "nameToHex" function. Also, I have moved this "nameToHex" function to the utils section for sharing between the newly created TestOwnedResolver and the old TestPublicResolver.