Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disable fallback behavior #253

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Conversation

tagliala
Copy link
Collaborator

@tagliala tagliala commented Nov 14, 2021

  1. Do not enable fallback if disable_fallback option is enabled
  2. Raise if the translation is not found, so that translate_path may
    rescue from it

Close #241

TODO:

  • failing test case

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 849e2dc on bugfix/fix-disable-fallback-241 into 95324fd on master.

@coveralls
Copy link

coveralls commented Nov 14, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 679294c on bugfix/fix-disable-fallback-241 into 4a559fb on master.

1. Do not enable fallback if disable_fallback option is enabled
2. Raise if the translation is not found, so that `translate_path` may
  rescue from it

Close #241
@tagliala tagliala force-pushed the bugfix/fix-disable-fallback-241 branch from 849e2dc to 679294c Compare November 28, 2021 16:45
@tagliala tagliala marked this pull request as ready for review November 28, 2021 17:16
@tagliala tagliala merged commit 45514d6 into master Nov 28, 2021
@tagliala tagliala deleted the bugfix/fix-disable-fallback-241 branch November 28, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable_fallback not working when I18n.fallbacks is configured
2 participants