Allow to hide_locale when using host_locales config

[WaKeMaTTa]

This is what I want to accomplish in this Pull Request:

HOST	PATH	Should be accessible?
testapp.es	/	✔️
	/mostrar	✔️
	/es/mostrar	❌
	/show	❌
	/en/show	❌
testapp.co.uk	/	✔️
	/show	✔️
	/en/show	❌
	/mostrar	❌
	/es/mostrar	❌

---

If you run my spec in master branch:

• test/integration/host_locales_with_hide_locale_test.rb

You will see that fails.

[tagliala]

Hi!

Thanks for this PR

Could you please fix the RuboCop offences and push force?

Please run specs using rake so it will also perform the linting

Could you also please clarify what you are trying to archive?

Locale is automatically hidden when using host_locales config

[coveralls]

Coverage remained the same at 100.0% when pulling b13041a on WaKeMaTTa:allow-to-hide-locale-with-host-locales-config into f154fb1 on enriclluelles:master.

[WaKeMaTTa]

@tagliala I updated the description Pull Request and I added some specs.

[tagliala]

Hi @WaKeMaTTa

Ok, I know exactly this issue (#171, from 2017) and you can find it fixed and documented on the branch 10-dev

Your tests pass on 10-dev.

Now I'm not using route_translator anymore in production, so that has not been merged because I don't know the side effects for other usages, but I can definitely release a version 10.0

Relevant commit and issues:

• 0aec9e4
• Avoid generating duplicate routes? #87
• Avoid duplicate routes in host locales #171

I did not release this change because the only comment in #171 is from someone that was using all the languages on all the domains. But again, I would support the case that makes most sense of all, leaving the developer the ability to provide a custom implementation

[WaKeMaTTa]

It works as intended. Thanks.

[tagliala]

Welcome. @WaKeMaTTa what do you think about this issue?

Should we release a new major with that change?

Should we preserve the ability of loading all languages on all hosts?

[WaKeMaTTa]

@tagliala I think this issue of having duplicated routes deserves a new major version. Because having more routes than necessary make things slower and confusing.

I saw that config verify_host_path_consistency in the branch 10-dev was removed AND it is the default behavior. I think is a good decision, because doesn't make sense to be able to access pages of other languages from other hosts.

[tagliala]

I think is a good decision, because doesn't make sense to be able to access pages of other languages from other hosts.

This weekend I will check if I can preserve the ability to have all languages on a single host for some edge cases (multi-domain / multi-language websites where the domain just sets the default locale), or provide some documentation on how to do that

I also think the time has come and I should merge this change in the stable version of Route Translator

[tagliala]

As per #171 (comment), I will release 10.0 with consistency lambdas enabled by default but I will keep the half-working implementation of the engine

I just need some tweaks to the wiki and to the docs

[tagliala]

Wiki: https://github.com/enriclluelles/route_translator/wiki/Use-all-languages-on-multiple-hosts

[tagliala]

@WaKeMaTTa released, please give a try

[WaKeMaTTa]

@tagliala done, looks great! 🎉