-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: missing dup on blocks #203
Conversation
@rogercampos thanks for this PR I need just two things:
|
test/dummy/config/locales/all.yml
Outdated
|
||
de-AT: | ||
routes: | ||
dummy: Attrappe | ||
show: anzeigen | ||
account: account_de |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
konto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
The dup of the `blocks` argument was removed on the last refactor of the route_set, but it was necessary. On the other hand, `defaults` doesn't need a dup since this is already done inside `::ActionDispatch::Routing::Mapper::Mapping.build`. The new test showcases the bug (404 response) with the previous code.
@tagliala done, I checked rails versions 5-0-stable, 5-1, 5-2 and 6-0, they all dup the defaults |
The dup of the
blocks
argument was removed on the last refactor of the route_set, but it was necessary. On the other hand,defaults
doesn't need a dup since this is already done inside::ActionDispatch::Routing::Mapper::Mapping.build
.The new test showcases the bug (404 response) with the previous code.