Skip to content

Commit

Permalink
Change test as per Rails 5.1.3 change
Browse files Browse the repository at this point in the history
We are going to assume that Rails is providing the correct behaviour
for this use case, so we change the test accordingly to make it pass.

Ref: rails/rails@ff7f4a7 rails/rails#29662
Close: #172
  • Loading branch information
tagliala committed Nov 12, 2017
1 parent 50c058c commit 05e973a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test/integration/engine_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@ class RoutingTest < ActionDispatch::IntegrationTest
include RouteTranslator::ConfigurationHelper

def test_with_engine_inside_localized_block
skip 'Regression with Rails 5.1.3. See #172'
get '/engine_es'
assert_response :success
assert_equal '/blorgh/posts', response.body
assert_equal '/es/blorgh/posts', response.body
end

def test_with_engine_outside_localized_block
Expand Down

0 comments on commit 05e973a

Please sign in to comment.