Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Clean up the imports #92

Closed
enpaul opened this issue Jun 21, 2023 · 0 comments
Closed

[Refactor] Clean up the imports #92

enpaul opened this issue Jun 21, 2023 · 0 comments
Labels
roadmap-stable Required for stable status

Comments

@enpaul
Copy link
Owner

enpaul commented Jun 21, 2023

Imports are currently done in a bunch of different ways through out the module. Ideally, all imports should be done using the full namespace they're importable under (i.e. instead of from foo import bar do import foo.bar) and should never change imported names (i.e. instead of import Foo as FizzFoo do import Foo). This should be standardized.
@enpaul enpaul added the roadmap-stable Required for stable status label Jun 21, 2023
@enpaul enpaul mentioned this issue Aug 15, 2024
Merged
enpaul added a commit that referenced this issue Aug 20, 2024
@enpaul
Standardize import structure
48b71bc 
Standardize on "import module" format rather than "from module import foo" format
Remove _poetry stub module since we directly depend on the poetry package now
Fix conflicts between modules and parameters both named 'poetry'
Fixes #92
@enpaul enpaul closed this as completed in 198287a Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
roadmap-stable Required for stable status
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@enpaul