Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User.modifiedTime should be optional in Core TS definitions #10221

Closed
ComLock opened this issue Jul 25, 2023 · 2 comments · Fixed by #10376
Closed

User.modifiedTime should be optional in Core TS definitions #10221

ComLock opened this issue Jul 25, 2023 · 2 comments · Fixed by #10376
Assignees
@edloidas
Labels
Bug Types Typings
Milestone
7.14.0

Comments

@ComLock
Copy link
Collaborator

ComLock commented Jul 25, 2023

https://github.com/enonic/xp/blob/c4b556fb79772d40e140e7a7eee9e117122f02be/modules/lib/core/index.d.ts#L32C26-L32C26
@ComLock ComLock added the Types Typings label Jul 25, 2023
@rymsha rymsha added the Bug label Jul 27, 2023
@rymsha
Copy link
Contributor

rymsha commented Jul 27, 2023

It is optional on update, but not optional on read, I think

@rymsha rymsha added this to the 7.14.0 milestone Jan 4, 2024
@rymsha rymsha assigned edloidas and unassigned ComLock Jan 4, 2024
@edloidas
Copy link
Member

edloidas commented Jan 4, 2024

Appears that we have some predefined users like ANONYMOUS who don't have a modifiedTime field.

edloidas added a commit that referenced this issue Jan 4, 2024
@edloidas
User.modifiedTime should be optional #10221
dffb7ca
@edloidas edloidas linked a pull request Jan 4, 2024 that will close this issue
User.modifiedTime should be optional #10221 #10376
Merged
rymsha pushed a commit that referenced this issue Jan 8, 2024
@edloidas @rymsha
User.modifiedTime should be optional #10221
883ab56
rymsha pushed a commit that referenced this issue Jan 8, 2024
@edloidas @rymsha
User.modifiedTime should be optional #10221
cef469a 
(cherry picked from commit 883ab56)
@alansemenov alansemenov changed the title User.modifiedTime should be optional User.modifiedTime should be optional in Core TS definitions Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edloidas edloidas

Labels
Bug Types Typings
Projects
None yet
Milestone
7.14.0
Development

Successfully merging a pull request may close this issue.

User.modifiedTime should be optional #10221 enonic/xp
3 participants
@ComLock @edloidas @rymsha