Make static serviceUrls in Java instead of the js assetUrl hack

[ComLock]

Make serviceUrl "root" which is on nearest site, not on every page.

Currently WRONG!
http://localhost:8080/site/starter-r4x-project/master/_/service/com.enonic.app.react4xp/react4xp/globals.js

Should be
http://localhost:8080/site/starter-r4x-project/master/mysite/_/service/com.enonic.app.react4xp/react4xp/globals.js

--
oldref: #452

[espen42]

@sigdestad and I have talked about using mapped controllers instead of services. A bit more setup for devs, but easier and more stable to handle after that.

[rymsha]

Now it is a task to use lib-static. Done?

[ComLock]

Actually it's not about using lib-static, it's about this hack which uses serviceUrl to make assetUrl.

lib-react4xp/src/main/resources/lib/enonic/react4xp/asset/assetUrl.ts

Line 88 in e8aa9f1

return `${serviceUrl}/${assetPath}`.replace(/\/{2,}/g, '/');

[ComLock]

Which in term is used in serviceUrlRoot

lib-react4xp/src/main/resources/lib/enonic/react4xp/dependencies/initServiceUrlRoot.ts

Lines 23 to 26 in e8aa9f1

	const serviceUrlRoot = assetUrl
	.replace(/\/edit\/([^\/]+)\/([^\/]+)\/_\/asset/,'/preview/$1/$2/_/asset') // Fix BUG Assets give 404 in edit mode #476
	.replace(/\/_\/asset\/.*$/, `/_/service/${app.name}/${serviceName}/`)
	.replace(/\/{2,}$/, '/');

[ComLock]

Actually it's not used in initServiceUrlRoot, but the one from portal is (which will be gone in xp8)

lib-react4xp/src/main/resources/lib/enonic/react4xp/dependencies/initServiceUrlRoot.ts

Line 4 in e8aa9f1

import { assetUrl as getAssetUrl } from '/lib/xp/portal';

[rymsha]

There are test failures @ComLock
Could you look at them?

[ComLock]

There are test failures @ComLock Could you look at them?

yes