This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Fix: DOM types #172
Merged
Fix: DOM types #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: - Node: A couple of type errors which were mistakenly introduced when excluding global DOM types - Web: Node types were mistakenly being included by `tsconfig.web.json`, as well as `src/dom/index.ts` (which wasn't actually in use, it was a naive first attempt at setting up aliasing for each target's DOM implementation)
lognaturel
approved these changes
Mar 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Node: A couple of type errors which were mistakenly introduced when excluding global DOM types
Web: Node types were mistakenly being included by
tsconfig.web.json, as well assrc/dom/index.ts(which wasn't actually in use, it was a naive first attempt at setting up aliasing for each target's DOM implementation)