This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Replace request with undici (Node's official fetch package), update dependencies, patch vulnerabilities #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [request](https://www.npmjs.com/package/request) library has been deprecated for some time. This change: 1. Replaces use of request (the library) with the `request` function from [undici](https://github.com/nodejs/undici), which has been adopted by Node to provide an implementation of the now-standard [`fetch`](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API) web API. This `request` API is almost but not quite identical to `fetch`, but undici's `fetch` is not available for some of our currently supported Node versions. 2. Refactors the three very similar dev-facing API endpoints provided by enketo-transformer's `app.js`. This isn't strictly necessary but it was easier to reason about than applying the same changes repeatedly, and... 3. ... caught/fixed a bug where the POST handler always returned a 400 Bad Request for valid POST bodies with an `xform` property.
Note: express was _downgraded_ to address a vulnerability in its qs subdependency. I don't expect any compatibility issues, and its usage here is dev-only. I also added types for express to validate this.
lognaturel
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in the commit notes.