This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Fix: regression when no media mapping provided #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change introduced in enketo#150 causes errors/inconsistent URL-escaping behavior when: - No media mapping is provided by the survey - A survey includes binary defaults - A survey references a `jr:` URL in markdown This fix restores the previous behavior, but incorporates the fix from enketo#150 to prevent incorrectly injecting paragraphs into markdown fragments.
eyelidlessness
requested review from
MartijnR and
lognaturel
and removed request for
MartijnR
|
Sorry for review request noise @MartijnR, tagged you by mistake while the reviewers menu was updating. (But of course you're welcome to take a look!) |
lognaturel
approved these changes
May 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduced in #150 causes errors/inconsistent URL-escaping behavior when:
jr:URL in markdownThis fix restores the previous behavior, but incorporates the fix from #150 to prevent incorrectly injecting paragraphs into markdown fragments.