Windows detach process #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the job flag 'JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE' will destroy all related processes once a job is destroyed. ref: https://docs.microsoft.com/en-us/windows/win32/procthread/job-objects#managing-job-objects
If a process is created with the 'CREATE_BREAKAWAY_FROM_JOB' flag then the job must also set the 'JOB_OBJECT_LIMIT_BREAKAWAY' flag. ref: https://docs.microsoft.com/en-us/windows/win32/procthread/process-creation-flags
|
Looks like there are similar failures on master 😭 |
|
Thanks for the PR! The CI failures seem completely unrelated to this PR. Given Ruby 2.3 is EOL, I will remove from our build matrix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.