Display friendlier error message when ffi not installed

enkessler · Sep 19, 2019 · e819417 · e819417
1 parent c0dd089
commit e819417
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/childprocess.rb b/lib/childprocess.rb
@@ -66,6 +66,12 @@ def jruby?
     end
 
     def windows?
+      begin
+        require 'ffi'
+      rescue LoadError
+        raise ChildProcess::MissingFFIError
+      end
+
       os == :windows
     end
 

diff --git a/lib/childprocess/errors.rb b/lib/childprocess/errors.rb
@@ -16,8 +16,8 @@ class LaunchError < Error
 
   class MissingFFIError < Error
     def initialize
-      message = "FFI is a required pre-requisite for posix_spawn, falling back to default implementation. " +
-                "Please add it to your deployment to unlock this functionality. " +
+      message = "FFI is a required pre-requisite for Windows or posix_spawn supporting the ChildProcess gem. " +
+                "Ensure the `ffi` gem is installed. " +
                 "If you believe this is an error, please file a bug at http://github.com/enkessler/childprocess/issues"
 
       super(message)