Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the driver name string is empty instead of just null. #37

Merged

Conversation

v16Studios
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08% ⚠️

Comparison is base (01f67dd) 92.41% compared to head (1c4d0de) 92.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
- Coverage     92.41%   92.33%   -0.08%     
- Complexity     1380     1381       +1     
============================================
  Files           244      244              
  Lines          6605     6604       -1     
============================================
- Hits           6104     6098       -6     
- Misses          501      506       +5     
Files Changed Coverage Δ
src/Services/Auth/AuthManager.php 72.00% <100.00%> (+1.16%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardocustodio leonardocustodio merged commit ac54970 into master Aug 8, 2023
6 checks passed
@leonardocustodio leonardocustodio deleted the bugfix/pla-1164/fix-default-auth-driver-resolution branch August 8, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants