Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLA-2062] Remove google qr adapter #284

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[PLA-2062] Remove google qr adapter #284

merged 1 commit into from
Oct 31, 2024

Conversation

leonardocustodio
Copy link
Member

@leonardocustodio leonardocustodio commented Oct 30, 2024 •
edited by github-actions bot
Loading

PR Type

enhancement

Description

  • Removed the GoogleQrAdapter class from the codebase, which was responsible for generating QR image URLs using Google Charts.
  • The removal includes the deletion of the implementation of the QrAdapterInterface and the associated method.

Changes walkthrough 📝

Relevant files
Enhancement
GoogleQrAdapter.php
Remove `GoogleQrAdapter` class and its functionality         

src/Services/Qr/Adapters/GoogleQrAdapter.php

  • Removed the GoogleQrAdapter class.
  • Deleted the implementation of the QrAdapterInterface.
  • Removed the method for generating QR image URLs using Google Charts.
    		•  +0/-18   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @leonardocustodio leonardocustodio self-assigned this Oct 30, 2024
    @github-actions GitHub Actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @github-actions GitHub Actions
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @leonardocustodio leonardocustodio merged commit 18009e1 into master Oct 31, 2024
    7 checks passed
    @leonardocustodio leonardocustodio deleted the PLA-2062 branch October 31, 2024 08:24
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @enjinabner enjinabner enjinabner approved these changes

    @v16Studios v16Studios Awaiting requested review from v16Studios v16Studios is a code owner

    Assignees

    @leonardocustodio leonardocustodio

    Labels
    Review effort [1-5]: 1
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @leonardocustodio @enjinabner