[PLA-2023] Refactor constant

[enjinabner]

PR Type

enhancement, tests

---

Description

• Introduced a constant URL_ENCODED_KEY in Laravel\Attribute to replace the hardcoded hex key.
• Updated SyncMetadata command to use the new constant instead of a hardcoded value.
• Modified model events in Attribute to utilize the constant for better maintainability.
• Updated test cases in GetTokenTest to use the constant, ensuring consistency across the codebase.

---

Changes walkthrough 📝

	Relevant files
Enhancement	SyncMetadata.php Use constant for URL encoded key in SyncMetadata                  src/Commands/SyncMetadata.php Added import for LaravelAttribute. Replaced hardcoded hex key with LaravelAttribute::URL_ENCODED_KEY. +2/-1      Attribute.php Introduce constant for URL encoded key in Attribute            src/Models/Laravel/Attribute.php Introduced constant URL_ENCODED_KEY. Replaced hardcoded hex key with the new constant in model events. +3/-2
Tests	GetTokenTest.php Update tests to use constant for URL encoded key                  tests/Feature/GraphQL/Queries/GetTokenTest.php Added import for LaravelAttribute. Replaced hardcoded hex key with LaravelAttribute::URL_ENCODED_KEY in tests. +3/-2

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Best practice	Use strict comparison for type safety in model event hooks Verify that the equality check against static::URL_ENCODED_KEY in the model's event hooks uses a strict comparison (===) to ensure type safety. src/Models/Laravel/Attribute.php [48-49] -if ($model->key == static::URL_ENCODED_KEY) { +if ($model->key === static::URL_ENCODED_KEY) { SyncMetadata::dispatch($model->id); } Suggestion importance[1-10]: 8 Why: The suggestion to use strict comparison (===) enhances type safety, which is a best practice in PHP to prevent unexpected type coercion, thereby improving code robustness.	8

fixed