Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Accept any gmajor version #274

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[Hotfix] Accept any gmajor version #274

merged 1 commit into from
Oct 17, 2024

Conversation

leonardocustodio
Copy link
Contributor

@leonardocustodio leonardocustodio commented Oct 17, 2024 •
edited by github-actions bot
Loading

PR Type

enhancement

Description

  • Updated the composer.json file to change the version constraint for the gmajor/sr25519-bindings dependency from ^1.0 to *, allowing for more flexibility in version selection.

Changes walkthrough 📝

Relevant files
Dependencies
composer.json
Update version constraint for gmajor/sr25519-bindings dependency

composer.json

  • Updated the version constraint for gmajor/sr25519-bindings from ^1.0
    to *.
    		•  +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @leonardocustodio
    Update composer.json
    56a4111 
    Signed-off-by: Leonardo Custodio <[email protected]>
    @github-actions GitHub Actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @github-actions GitHub Actions
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @leonardocustodio leonardocustodio changed the title Update composer.json [Hotfix] Accept any gmajor version Oct 17, 2024
    @leonardocustodio leonardocustodio merged commit b2d95e0 into master Oct 17, 2024
    6 of 7 checks passed
    @leonardocustodio leonardocustodio deleted the patch-gmajor branch October 17, 2024 14:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Bradez Bradez Bradez approved these changes

    @v16Studios v16Studios Awaiting requested review from v16Studios v16Studios is a code owner

    @enjinabner enjinabner Awaiting requested review from enjinabner enjinabner is a code owner

    Assignees
    No one assigned
    Labels
    enhancement New feature or request Review effort [1-5]: 1
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @leonardocustodio @Bradez