Skip to content

Commit

Permalink
Correct Typos
Browse files Browse the repository at this point in the history
  • Loading branch information
wangbin579 committed Oct 22, 2024
1 parent f4dc4f9 commit 5231664
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions binlog_group.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ First, capture performance problems during the TPC-C test with 500 concurrency u

![](images/66a031ab14d56289d0987c65c73323af.png)

Figure 1. *_pthread_mutex_con_lock* bottleneck reveals performance problems.
Figure 1. *_pthread_mutex_cond_lock* bottleneck reveals performance problems.

It is evident that *_pthread_mutex_con_lock* is a significant bottleneck, accounting for approximately 9.5% of the overhead. Although *perf* does not directly pinpoint the exact problem, it indicates the presence of this bottleneck.
It is evident that *_pthread_mutex_cond_lock* is a significant bottleneck, accounting for approximately 9.5% of the overhead. Although *perf* does not directly pinpoint the exact problem, it indicates the presence of this bottleneck.

To address the problem, an in-depth exploration of MySQL internals was conducted to uncover the factors contributing to this performance bottleneck. A conventional binary search approach with minimal logging was used to identify functions or code segments that incur significant overhead during execution. The minimal logging approach was chosen to reduce performance interference while diagnosing the root cause of the problem. Excessive logging can disrupt performance analysis, and while some may use MySQL's internal mechanisms for troubleshooting, these often introduce substantial performance overhead themselves.

Expand Down Expand Up @@ -126,11 +126,11 @@ Figure 4. Impact of group commit optimization using standard configurations.
From the figure, it is clear that this optimization is less pronounced compared to the previous one, but it still shows overall improvement. Extensive testing indicates that the worse the scalability of MySQL, the more significant the effectiveness of binlog group commit optimization.
At the same time, the previously identified bottleneck of *_pthread_mutex_con_lock* has been significantly alleviated after optimization, as shown in the following figure:
At the same time, the previously identified bottleneck of *_pthread_mutex_cond_lock* has been significantly alleviated after optimization, as shown in the following figure:
![](images/8f9080ee71094d948ab7592b449954bb.png)
Figure 5. Mitigation of *_pthread_mutex_con_lock* bottleneck.
Figure 5. Mitigation of *_pthread_mutex_cond_lock* bottleneck.
In summary, this optimization helps address scalability problems associated with binlog group commit.
Expand Down
6 changes: 3 additions & 3 deletions performance_degradation.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ The MySQL 8.0.27 release version already had this problem, whereas the earlier M
commit 9a13c1c6971f4bd56d143179ecfb34cca8ecc018
Author: Steinar H. Gunderson <[email protected]>
Date: Tue Jun 8 15:14:35 2021 +0200

Bug #32976857: REMOVE QEP_TAB_STANDALONE [range optimizer, noclose]

Remove the QEP_TAB dependency from test_quick_select() (ie., the range
optimizer).

Change-Id: Ie0fcce71dfc813920711c43c3d62635dae0d7d20
```
Expand Down

0 comments on commit 5231664

Please sign in to comment.