Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added event system that was supposed to be added in. #52

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

SpinnerX
Copy link
Member

@SpinnerX SpinnerX commented Oct 9, 2024

Updated the engine3d codebase to utilize the .hpp file extension to be more consistent. This commit also includes comments that I added to add some clarity as to what some of the Vulkan physical and logical devices are supposed to be doing.

…, modified header extensions to hpp, including adding in the event-system into this commit
@SpinnerX SpinnerX changed the title Added basic event system that was supposed to be added in. Added event system that was supposed to be added in. Oct 9, 2024
Copy link
Member

@ZacharyH777 ZacharyH777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HPP, comments and a couple tests. Looks good to me.

@SpinnerX SpinnerX merged commit 1a99c86 into engine3d-dev:main Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants