forked from flutter/packages
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "Remove dual_screen from new_gallery integration test" (#150873)
Relands flutter/flutter#150808 The original version of the pr [accidentally deleted the back button](flutter/flutter#150808 (comment)), which didn't block the app building but made the test hang because it couldn't back out of the demo pages. Repro-ed the failure, and then tested that ``` new_gallery_opengles_impeller__transition_perf new_gallery__transition_perf new_gallery_impeller_old_zoom__transition_perf new_gallery__crane_perf new_gallery_impeller__transition_perf ``` All pass on my pixel 7 pro, with ` dart bin/test_runner.dart test -t <test>`, after re-adding the mistakenly deleted content. Did not test on an iOS device (I don't have one), but those tests were failing for the same reason from what I can tell: ``` > reply@study [2024-06-26 12:49:21.884543] [STDOUT] stdout: [ ] scrolling to demo [2024-06-26 12:49:22.412479] [STDOUT] stdout: [ +527 ms] tapping demo [2024-06-26 12:49:28.075978] [STDOUT] stderr: [+5663 ms] VMServiceFlutterDriver: tap message is taking a long time to complete... ``` Which is the same error, and which makes sense - they got stuck because they couldn't back out of the page. Sorry for the churn �
- Loading branch information
Showing
9 changed files
with
55 additions
and
433 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
226 changes: 0 additions & 226 deletions
226
dev/integration_tests/new_gallery/lib/demos/reference/two_pane_demo.dart
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.