fix: typo #15
Merged
fix: typo #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zhigang1992, thanks for the contribution. I will check it 👍🏽 |
zhigang1992
commented
Mar 29, 2021
src/components/menu/types.d.ts
Outdated
| @@ -6,7 +6,11 @@ export type MenuItemProps = { | |||
| onPress: () => void; | |||
| isTitle?: boolean; | |||
| isDestructive?: boolean; | |||
| /** | |||
| * @deprecated typo here for compatibility | |||
| */ | |||
There was a problem hiding this comment.
I kept the old field so this is not a breaking change.
There was a problem hiding this comment.
This is exactly well thought update but I removed it, package is already very early stage and not used for many people now. Will continue with other typo fixes 🙌🏽
enesozturk
added a commit
that referenced
this pull request
May 15, 2021
* feat: Add Tap and Double Tap Support * fix: remove unnecessary memo * fix: disable calling animations again when they are already active * feat: new prop to pass params to onPress handlers * feat: add optional haptic feedback * chore: replace react-native-haptic-feedback with expo-haptics * chore: update yarn lock and prop example usage * chore: make methodParams optional * chore: rename methodParams prop name as actionParams * chore: update actionParams prop types * docs: update props doc for actionParams * docs: add haptic feedback and activate on props * refactor: updates reanimated and unimodules deps and setups (#25) * fix: typo for seperator word (#15) * fix: typo * chore: remove all typo for seperator Co-authored-by: Enes Ozturk <[email protected]> * feat: disable touchable of the hold item when menu active (#8) * feat: optional prop to close menu when tap to hold item * docs: add closeOnTap to the props * chore: update whatsapp example * refactor: update hold item comp and types * feat: new icon component usage logic (#24) * feat: add animated icon component * chore: remove theme prop passing to children * chore: update playground example with hold menu icon comp * chore: update icon handling logic * chore: update icon rendering in menu item * chore: updates examples and pass feather icons to hold menu * chore: update telegram example * docs: add icon docs and update other details * fix: typo for separator word that missed on rebase (#26) * fix: typo for separator word that missed on rebase * chore: update wrong separator words * chore: release v0.1.0 Co-authored-by: ksitko <[email protected]> Co-authored-by: Zhigang Fang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.