feat(issuer): Smart Contract Improvements #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…ivate Issuer contract BREAKING CHANGE: There is a new set of Issuer and Registry smart contracts that is based on OpenZeppelin's ERC-1155 contracts and not backwards compatible with the previous smart contracts
…s in Issuer and Registry smart contracts
… OpenZeppelin instead of Origin implementation BREAKING CHANGE: New smart contracts incompatible with the previous smart contracts
josipbagaric
force-pushed
the
feat/updated-1155
branch
from
9f85c23
to
9cf5489
Compare
josipbagaric
changed the title
soanvig
reviewed
May 5, 2021
packages/traceability/issuer-api/src/pods/blockchain/blockchain-properties.dto.ts
Show resolved
Hide resolved
|
|
||
| wrap(signerOrPrivateKey?: Signer | string): IBlockchainProperties { | ||
| const web3 = getProviderWithFallback(this.rpcNode, this.rpcNodeFallback); | ||
| const web3 = getProviderWithFallback( | ||
| ...[this.rpcNode, this.rpcNodeFallback].filter((url) => !!url) |
There was a problem hiding this comment.
Just a super NIT, but for that kind of functions it's nice to have a helper. lodash has compact.
For this case though maybe you consider .filter(Boolean) since it better explains intention? It's just my opinion though.
packages/trade/exchange-io-erc1888/src/deposit-watcher/deposit-watcher.service.ts
Show resolved
Hide resolved
kosecki123
reviewed
May 10, 2021
kosecki123
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrivateIssuer.solencodeDataanddecodeDatafrom smart contracts, since we now have an off-chain implementationprivateIssuercontract as an optional contract toBlockchainProperties