Invoke the rust compiler for the appropriate tool chain

[dtolnay]

Description

When a RUSTC_WRAPPER is set, Cargo passes in its first argument a path to the right rustc executable it wants the wrapper to delegate to. See Environment variables Cargo reads. "Instead of simply running rustc, Cargo will execute this specified wrapper, passing as its command-line arguments the rustc invocation, with the first argument being the path to the actual rustc."

For example, RUSTC_WRAPPER=/path/to/mirai cargo +nightly-2023-12-30 check would end up running /path/to/mirai $RUSTUP_HOME/toolchains/nightly-2023-12-30-x86_64-unknown-linux-gnu/bin/rustc --crate-name=whatever --edition=2021 src/lib.rs ...

$RUSTC is in general not set by Cargo when running a subcommand such as cargo-mirai.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• API change with a documentation update
• Additional test coverage
• Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

In MIRAI: cargo build --release
In another crate: PATH=$PATH:/path/to/mirai/target/release cargo +nightly-2023-12-30 mirai

[hermanventer]

Many thanks for this David. I'm on vacation right now but I'll try to merge it on Friday. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: David Tolnay ***@***.***> Sent: Monday, October 14, 2024 6:38:39 PM To: endorlabs/MIRAI ***@***.***> Cc: Subscribed ***@***.***> Subject: [endorlabs/MIRAI] Invoke the rust compiler for the appropriate tool chain (PR #4) Description When a RUSTC_WRAPPER is set, Cargo passes in its first argument a path to the right rustc executable it wants the wrapper to delegate to. See Environment variables Cargo reads<https://doc.rust-lang.org/1.81.0/cargo/reference/environment-variables.html#environment-variables-cargo-reads>. "Instead of simply running rustc, Cargo will execute this specified wrapper, passing as its command-line arguments the rustc invocation, with the first argument being the path to the actual rustc." For example, RUSTC_WRAPPER=/path/to/mirai cargo +nightly-2023-12-30 check would end up running /path/to/mirai $RUSTUP_HOME/toolchains/nightly-2023-12-30-x86_64-unknown-linux-gnu/bin/rustc --crate-name=whatever --edition=2021 src/lib.rs ... $RUSTC is in general not set by Cargo when running a subcommand such as cargo-mirai. Type of change * Bug fix (non-breaking change which fixes an issue) * New feature (non-breaking change which adds functionality) * Breaking change (fix or feature that would cause existing functionality to not work as expected) * API change with a documentation update * Additional test coverage * Code cleanup or just keeping up with the latest Rustc nightly How Has This Been Tested? In MIRAI: cargo build --release In another crate: PATH=$PATH:/path/to/mirai/target/release cargo +nightly-2023-12-30 mirai

________________________________ You can view, comment on, or merge this pull request online at: #4 Commit Summary * 7f9f044<7f9f044> Invoke the rust compiler for the appropriate tool chain File Changes (1 file<https://github.com/endorlabs/MIRAI/pull/4/files>) * M checker/src/cargo_mirai.rs<https://github.com/endorlabs/MIRAI/pull/4/files#diff-3c8f3493963db62e8e33dbb3c112ef9dac2c74f1e20715b40b307ed115310348> (12) Patch Links: * https://github.com/endorlabs/MIRAI/pull/4.patch * https://github.com/endorlabs/MIRAI/pull/4.diff — Reply to this email directly, view it on GitHub<#4>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABA77AYKSSO5A5X6HPZB6VLZ3P6R7AVCNFSM6AAAAABP5O7BW2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4DMNRWGEYDSNQ>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- **Confidentiality Notice: *This email and any attachments are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error, please notify the sender immediately and delete it from your system. Unauthorized use, disclosure, or copying of this email or its contents is strictly prohibited.*