Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marshal's Hilbert processing should only freeze rest, not harden it. #994

Merged
merged 1 commit into from
Jan 23, 2022
Merged

marshal's Hilbert processing should only freeze rest, not harden it. #994

merged 1 commit into from
Jan 23, 2022

Conversation

erights
Copy link
Contributor

@erights erights commented Jan 20, 2022

@erights erights requested a review from mhofman January 20, 2022 05:15
@erights erights self-assigned this Jan 20, 2022
kriskowal
kriskowal requested changes Jan 20, 2022
View reviewed changes
Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please keep off master until a release commit appears before ff68d33 in the log in chronological order. I will lift “request changes” at that time.

@erights erights force-pushed the 4313-markm-soften-hilbert branch from 039ad9f to 455c485 Compare January 21, 2022 06:19
kriskowal
kriskowal approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master is released and clear for changes.

@erights erights force-pushed the 4313-markm-soften-hilbert branch from 455c485 to 19b487e Compare January 23, 2022 04:20
@erights erights merged commit edeaf8a into master Jan 23, 2022
@erights erights deleted the 4313-markm-soften-hilbert branch January 23, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhofman mhofman mhofman approved these changes

@kriskowal kriskowal kriskowal approved these changes

Assignees

@erights erights

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

serialize tries to harden hilbert
3 participants
@erights @kriskowal @mhofman