Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ses): permit Promise.prototype.try #2609

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

erights
Copy link
Contributor

@erights erights commented Oct 23, 2024

Closes: #2607

Description

"There is no do. There is only try."
—Noda

See also https://github.com/tc39/proposal-promise-try

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

one less divergence to document.

Testing Considerations

none

Compatibility Considerations

better

Upgrade Considerations

nothing breaking.

@erights erights self-assigned this Oct 23, 2024
@erights erights force-pushed the markm-2607-permit-promise-try branch 2 times, most recently from 354a325 to daba7f9 Compare October 23, 2024 20:11
@erights erights requested a review from kriskowal October 23, 2024 20:11
Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it, but Promise.try needs to be on the constructor and not the prototype.

@kriskowal
Copy link
Member

I’m abandoning this change ec5a9b4

@erights
Copy link
Contributor Author

erights commented Oct 24, 2024

You beat me to it, but Promise.try needs to be on the constructor and not the prototype.

Doh! Fixed. PTAL

@erights erights requested a review from kriskowal October 24, 2024 18:05
@erights erights force-pushed the markm-2607-permit-promise-try branch from 11c75d8 to a8e6a63 Compare October 24, 2024 21:20
@erights erights enabled auto-merge (squash) October 24, 2024 21:21
@erights erights merged commit d37a434 into master Oct 24, 2024
15 checks passed
@erights erights deleted the markm-2607-permit-promise-try branch October 24, 2024 21:32
boneskull added a commit that referenced this pull request Nov 4, 2024
# By Turadg Aleahmad (11) and others
# Via GitHub (4) and Kris Kowal (1)
* master:
  docs(ses): Finish embracing permits terminology
  fix(ses): Clarify lockdown types
  feat(ses): Lockdown reporting option
  chore(deps): yarn dedupe
  chore(types): fix import tags
  lint: enable jsdoc/recommended-typescript-flavor
  chore: rm dup config key
  chore(deps): bump eslint-plugin-jsdoc
  build(deps): bump typescript (patch)
  chore(types): conform to verbatimModuleSyntax
  ci: enable verbatimModuleSyntax
  style: prettier
  chore(deps): bump prettier
  build(deps): bump yarn to 4.5.1
  feat(compartment-mapper): Collect unretained module descriptors
  test(compartment-mapper): Mark and sweep unused module descriptors
  feat(ses): permit Promise.prototype.try (#2609)

# Conflicts:
#	packages/compartment-mapper/NEWS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permit Promise.try
2 participants