fix(ses): warn on unsupported lockdownOptions mathTaming + dateTaming #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumavis
force-pushed
the
ses-warn-options-date-math-taming
branch
2 times, most recently
from
f9daa18 to
5ca0413
Compare
kumavis
force-pushed
the
ses-warn-options-date-math-taming
branch
from
5ca0413 to
50c924f
Compare
kriskowal
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for lockdown options
mathTaminganddateTamingwere removed in July 2020. Since these options don't do anything, lockdown should warn when these options are specified.For LavaMoat, we were surprised to find they were being provided to lockdown, but had no effect. Any other unrecognized lockdown options are rejected.
Here is a PR for a breaking change that fully removes the options #2583