refactor(compartment-mapper): Pivot to module descriptors #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
kriskowal
force-pushed
the
kriskowal-ses-module-descriptors-xs-parity
branch
from
6320908 to
68d8f93
Compare
kriskowal
force-pushed
the
kriskowal-no-compartment-module-method
branch
from
e93e409 to
03132e1
Compare
kriskowal
force-pushed
the
kriskowal-ses-module-descriptors-xs-parity
branch
from
68d8f93 to
984d3d2
Compare
kriskowal
force-pushed
the
kriskowal-no-compartment-module-method
branch
from
03132e1 to
7fc4f9a
Compare
kriskowal
force-pushed
the
kriskowal-ses-module-descriptors-xs-parity
branch
from
984d3d2 to
debd810
Compare
kriskowal
force-pushed
the
kriskowal-no-compartment-module-method
branch
from
7fc4f9a to
b184ed8
Compare
kriskowal
force-pushed
the
kriskowal-ses-module-descriptors-xs-parity
branch
from
debd810 to
5998c1b
Compare
kriskowal
force-pushed
the
kriskowal-no-compartment-module-method
branch
from
b184ed8 to
7a668b2
Compare
kriskowal
force-pushed
the
kriskowal-ses-module-descriptors-xs-parity
branch
from
5998c1b to
18796bc
Compare
kriskowal
force-pushed
the
kriskowal-no-compartment-module-method
branch
from
7a668b2 to
4261217
Compare
Base automatically changed from
kriskowal-ses-module-descriptors-xs-parity
to
master
July 16, 2024 00:14
…omaprtment.module()
kriskowal
force-pushed
the
kriskowal-no-compartment-module-method
branch
from
4261217 to
c38ea2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #400
Description
XS does not support
compartment.module. Rather than emulate it, I chose bring SES into closer alignment with XS module descriptors and use those instead. The Compartment Mapper is the only place we use this feature at the moment.Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
The existing Compartment Mapper tests exercise this path rigorously.
Compatibility Considerations
The new version of Compartment Mapper will not work with an older version of SES. Lerna will make sure the constraint gets updated when we release.
Upgrade Considerations
None.