more typedoc #1928
more typedoc #1928
Conversation
| @@ -4,16 +4,16 @@ export {}; | |||
| /** | |||
| * @template Slot | |||
| * @callback ConvertValToSlot | |||
| * @param {import('@endo/pass-style').PassableCap} val | |||
| * @param {any} val a PassableCap | |||
There was a problem hiding this comment.
That seems like a terrible regression, possibly due to types not being built!
There was a problem hiding this comment.
It's not a regression. PassableCap in master is any.
There was a problem hiding this comment.
Then the issue is with the PassableCap definition, not this param definition.
There was a problem hiding this comment.
There was indeed an issue with the PassableCap definition. It was any. The type is still any so there's no regression here.
Once we fix those types, I expect to return to this.
| import * as url from 'url'; | ||
| import * as process from 'process'; | ||
| import * as fs from 'fs'; |
There was a problem hiding this comment.
What is the significance of this change? Why didn't it cause anything else to change?
There was a problem hiding this comment.
These Node modules have no default exports. Under CommonJS the set of named exports could be treated as an object but under ESM you have to bundle the named exports into an object if you want to access them that way.
| @@ -6,6 +6,11 @@ import { makeMarshal } from '../src/marshal.js'; | |||
|
|
|||
| const { freeze, isFrozen, create, prototype: objectPrototype } = Object; | |||
|
|
|||
| const harden = /** @type {import('ses').Harden & {isFake: boolean}} */ ( | |||
There was a problem hiding this comment.
Would the following also work? If so, I think it better documents the runtime reality it describes. Likewise for the other occurrences of course
| const harden = /** @type {import('ses').Harden & {isFake: boolean}} */ ( | |
| const harden = /** @type {import('ses').Harden & {isFake?: boolean}} */ ( |
There was a problem hiding this comment.
Yes it would. I'll see about adding tacking that onto another PR.
Description
Enables typedoc for these packages:
realpathSyncargumentanyandstringtypes that it was trying to import frompass-stylebut failingSecurity Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations