Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Neutralize test fixtures #1247

Merged
merged 1 commit into from
Sep 1, 2022
Merged

chore: Neutralize test fixtures #1247

merged 1 commit into from
Sep 1, 2022

Conversation

kriskowal
Copy link
Member

Security researcher @nvk0x pointed out to us that anyone attempting to run npm install or yarn install in one of the Compartment Mapper test fixtures would be vulnerable to an attacker who had published one of its fake dependencies. Although this would not occur during normal development of this project, to entirely deny the possibility of such an attack, I've added a preinstall script to each of these fixtures to place a guard rail and preclude such an accident. Thank you to @nvk0x for pointing out the hazard.

@kriskowal kriskowal requested a review from naugtur August 24, 2022 01:56
Copy link
Member

@naugtur naugtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a stronger solution, where we put all packages in an @scope/package under a scope we control and nest the fixtures one more level.
But let's merge this first and think if we want to upgrade later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants